Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libx265: apply some global AVCodecContext settings to the encoder context

2019-12-30 Thread Derek Buitenhuis
On 28/12/2019 23:55, James Almer wrote: > +if (avctx->gop_size >= 0) > +ctx->params->keyframeMax = avctx->gop_size; For this patch and the others, you should call x265_param_parse with the correct key for these (kind of how librav1e.c does). x265 is not great at struct ABI compatabilit

[FFmpeg-devel] [PATCH 1/3] avcodec/libx265: apply some global AVCodecContext settings to the encoder context

2019-12-28 Thread James Almer
There's no reason to ignore them if set. Signed-off-by: James Almer --- doc/encoders.texi| 14 ++ libavcodec/libx265.c | 13 + 2 files changed, 27 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index a207363650..673eaf6496 100644 --- a/doc/encoders.