Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-19 Thread James Almer
On 7/18/2016 8:56 PM, Michael Niedermayer wrote: > On Mon, Jul 18, 2016 at 01:56:29PM -0300, James Almer wrote: >> On 7/12/2016 6:36 PM, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavformat/oggparsevp8.c | 6 +- >>> 1 file changed, 5 insertions(+), 1

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-18 Thread Michael Niedermayer
On Mon, Jul 18, 2016 at 01:56:29PM -0300, James Almer wrote: > On 7/12/2016 6:36 PM, James Almer wrote: > > Signed-off-by: James Almer > > --- > > libavformat/oggparsevp8.c | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > Ping for patchset. you are the

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-18 Thread James Almer
On 7/12/2016 6:36 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/oggparsevp8.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Ping for patchset. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-12 Thread James Almer
On 7/12/2016 7:52 PM, Moritz Barsnick wrote: > On Tue, Jul 12, 2016 at 18:36:20 -0300, James Almer wrote: >> +uint32_t invcnt = !((granule >> 30) & 3); > > If it's just for storing a 0/1 (bool, basically), wouldn't you use the > more unspecific type "int"? (Not sure whether it matters at

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-12 Thread Moritz Barsnick
On Tue, Jul 12, 2016 at 18:36:20 -0300, James Almer wrote: > +uint32_t invcnt = !((granule >> 30) & 3); If it's just for storing a 0/1 (bool, basically), wouldn't you use the more unspecific type "int"? (Not sure whether it matters at all.) Moritz

[FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-12 Thread James Almer
Signed-off-by: James Almer --- libavformat/oggparsevp8.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/oggparsevp8.c b/libavformat/oggparsevp8.c index d57419e..3ba5375 100644 --- a/libavformat/oggparsevp8.c +++ b/libavformat/oggparsevp8.c