Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-07 Thread Clément Bœsch
On Mon, Dec 07, 2015 at 11:35:34AM +0100, Clément Bœsch wrote: > On Sun, Dec 06, 2015 at 12:20:28PM +0100, Nicolas George wrote: > [...] > > > +static void free_func_wrap(void *arg, void *msg, int size) > > > +{ > > > +void (*free_func)(void *msg) = arg; > > > > Technically, this is not legal:

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-07 Thread Clément Bœsch
On Sun, Dec 06, 2015 at 12:20:28PM +0100, Nicolas George wrote: [...] > > +static void free_func_wrap(void *arg, void *msg, int size) > > +{ > > +void (*free_func)(void *msg) = arg; > > Technically, this is not legal: void* is a data pointer, it could be smaller > than a function pointer (reme

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-06 Thread Nicolas George
Le quartidi 14 frimaire, an CCXXIV, Clement Boesch a écrit : > From: Clément Bœsch > > --- > libavutil/threadmessage.c | 31 +++ > libavutil/threadmessage.h | 16 > 2 files changed, 47 insertions(+) > > diff --git a/libavutil/threadmessage.c b/libavu

[FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-04 Thread Clément Bœsch
From: Clément Bœsch --- libavutil/threadmessage.c | 31 +++ libavutil/threadmessage.h | 16 2 files changed, 47 insertions(+) diff --git a/libavutil/threadmessage.c b/libavutil/threadmessage.c index b7fcbe2..a5f1507 100644 --- a/libavutil/threadmessa

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 05:09:23PM +0100, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXIV, Clement Boesch a écrit : > > What would be the difference? both av_fifo_generic_peek and > > av_fifo_generic_peek_at require a copy of the element in a destination > > buffer, unless I'm missing somet

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Nicolas George
Le duodi 12 frimaire, an CCXXIV, Clement Boesch a écrit : > What would be the difference? both av_fifo_generic_peek and > av_fifo_generic_peek_at require a copy of the element in a destination > buffer, unless I'm missing something. As I see it, av_fifo_generic_peek() does NOT require a copy if a

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 04:59:15PM +0100, Nicolas George wrote: [...] > > +av_fifo_generic_peek_at(mq->fifo, mq->tmp_msg, off, > > mq->elsize, NULL); > > +mq->free_func(mq->tmp_msg); > > Could this use av_fifo_generic_peek() to avoid the ugly extra allocation? > What wou

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Nicolas George
Le duodi 12 frimaire, an CCXXIV, Clement Boesch a écrit : > From: Clément Bœsch > > --- > libavutil/threadmessage.c | 32 > libavutil/threadmessage.h | 12 > 2 files changed, 44 insertions(+) > > diff --git a/libavutil/threadmessage.c b/libavutil/th

[FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch --- libavutil/threadmessage.c | 32 libavutil/threadmessage.h | 12 2 files changed, 44 insertions(+) diff --git a/libavutil/threadmessage.c b/libavutil/threadmessage.c index b7fcbe2..66b5fc6 100644 --- a/libavutil/threadmessage.

[FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch --- libavutil/threadmessage.c | 37 ++--- libavutil/threadmessage.h | 21 ++--- 2 files changed, 52 insertions(+), 6 deletions(-) diff --git a/libavutil/threadmessage.c b/libavutil/threadmessage.c index b7fcbe2..87ce8dc 100644