Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-04-16 Thread Philip Langdale
On Thu, 16 Apr 2020 14:07:49 -0300 James Almer wrote: > On 4/16/2020 1:26 PM, Philip Langdale wrote: > > On Tue, 10 Mar 2020 16:33:41 -0300 > > James Almer wrote: > >> > >> I can withdraw this patch (And remove the relevant chunks from the > >> following two) if this function was effectively

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-04-16 Thread James Almer
On 4/16/2020 1:26 PM, Philip Langdale wrote: > On Tue, 10 Mar 2020 16:33:41 -0300 > James Almer wrote: >> >> I can withdraw this patch (And remove the relevant chunks from the >> following two) if this function was effectively not meant for >> encoders. Also maybe poke Timo regarding nvenc

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-04-16 Thread Philip Langdale
On Tue, 10 Mar 2020 16:33:41 -0300 James Almer wrote: > > I can withdraw this patch (And remove the relevant chunks from the > following two) if this function was effectively not meant for > encoders. Also maybe poke Timo regarding nvenc flushing, to see why > it is needed and if there's an

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-03-10 Thread James Almer
On 3/10/2020 4:08 PM, Anton Khirnov wrote: > Quoting James Almer (2020-03-10 19:14:47) >> On 3/10/2020 3:03 PM, Anton Khirnov wrote: >>> Quoting James Almer (2020-02-27 19:01:59) It's not a decoding exclusive function. >>> >>> How come? The doxy for it says >>> 'Reset the internal decoder

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-03-10 Thread Anton Khirnov
Quoting James Almer (2020-03-10 19:14:47) > On 3/10/2020 3:03 PM, Anton Khirnov wrote: > > Quoting James Almer (2020-02-27 19:01:59) > >> It's not a decoding exclusive function. > > > > How come? The doxy for it says > > 'Reset the internal decoder state / flush internal buffers.' > > It touches

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-03-10 Thread James Almer
On 3/10/2020 3:03 PM, Anton Khirnov wrote: > Quoting James Almer (2020-02-27 19:01:59) >> It's not a decoding exclusive function. > > How come? The doxy for it says > 'Reset the internal decoder state / flush internal buffers.' It touches some fields used by encode.c, like draining and

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-03-10 Thread Anton Khirnov
Quoting James Almer (2020-02-27 19:01:59) > It's not a decoding exclusive function. How come? The doxy for it says 'Reset the internal decoder state / flush internal buffers.' -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-02-27 Thread James Almer
It's not a decoding exclusive function. Signed-off-by: James Almer --- libavcodec/decode.c | 36 libavcodec/utils.c | 33 + 2 files changed, 33 insertions(+), 36 deletions(-) diff --git a/libavcodec/decode.c