Re: [FFmpeg-devel] [PATCH 1/4] dnxhddec: implement slice multithreading

2015-09-26 Thread Michael Niedermayer
On Sat, Sep 26, 2015 at 02:42:27PM +0200, Christophe Gisquet wrote: > Hi, > > 2015-09-26 1:52 GMT+02:00 Michael Niedermayer : > > This segfaults with > > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket2125/DNxHDtest2.mov > > Patch reworked: > - Preallocate RowContext to avoid reloading it > -

Re: [FFmpeg-devel] [PATCH 1/4] dnxhddec: implement slice multithreading

2015-09-26 Thread Christophe Gisquet
Hi, 2015-09-26 1:52 GMT+02:00 Michael Niedermayer : > This segfaults with > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket2125/DNxHDtest2.mov Patch reworked: - Preallocate RowContext to avoid reloading it - Use of init_thread_copy due to that - Fix crashes due to mishandling of code around ex

Re: [FFmpeg-devel] [PATCH 1/4] dnxhddec: implement slice multithreading

2015-09-26 Thread Michael Niedermayer
On Sat, Sep 26, 2015 at 08:33:26AM +0200, Christophe Gisquet wrote: > Hi, > > 2015-09-26 1:52 GMT+02:00 Michael Niedermayer : > > This segfaults with > > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket2125/DNxHDtest2.mov > > Can't reproduce with frame or slice threading or no threading. What >

Re: [FFmpeg-devel] [PATCH 1/4] dnxhddec: implement slice multithreading

2015-09-26 Thread Christophe Gisquet
Hi, 2015-09-26 8:33 GMT+02:00 Christophe Gisquet : > Is it something that should be avoidable through my code? I now think so, so please ignore me till I've understood all of the API. -- Christophe ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/4] dnxhddec: implement slice multithreading

2015-09-25 Thread Christophe Gisquet
Hi, 2015-09-26 1:52 GMT+02:00 Michael Niedermayer : > This segfaults with > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket2125/DNxHDtest2.mov Can't reproduce with frame or slice threading or no threading. What was the command-line? > #3 0x00af53fd in avcodec_default_execute2 (c=0x1c

Re: [FFmpeg-devel] [PATCH 1/4] dnxhddec: implement slice multithreading

2015-09-25 Thread Michael Niedermayer
On Fri, Sep 25, 2015 at 11:25:06PM +0200, Christophe Gisquet wrote: > Around 3x speedup with 4 threads. Maybe more mb lines should be > batched per thread, but that's good enough for a first try. > --- > libavcodec/dnxhddec.c | 221 > ++ > 1 file ch

[FFmpeg-devel] [PATCH 1/4] dnxhddec: implement slice multithreading

2015-09-25 Thread Christophe Gisquet
Around 3x speedup with 4 threads. Maybe more mb lines should be batched per thread, but that's good enough for a first try. --- libavcodec/dnxhddec.c | 221 ++ 1 file changed, 133 insertions(+), 88 deletions(-) diff --git a/libavcodec/dnxhddec.c b/l