Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-16 Thread Michael Niedermayer
On Tue, Oct 15, 2019 at 08:44:23PM +1100, Peter Ross wrote: > On Mon, Oct 14, 2019 at 10:06:55PM +0200, Michael Niedermayer wrote: > > On Sun, Oct 13, 2019 at 10:51:49AM +1100, Peter Ross wrote: > > > On Sat, Oct 12, 2019 at 06:53:05PM -0300, James Almer wrote: > > > > On 10/12/2019 5:47 PM, Michae

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-15 Thread Peter Ross
On Mon, Oct 14, 2019 at 10:06:55PM +0200, Michael Niedermayer wrote: > On Sun, Oct 13, 2019 at 10:51:49AM +1100, Peter Ross wrote: > > On Sat, Oct 12, 2019 at 06:53:05PM -0300, James Almer wrote: > > > On 10/12/2019 5:47 PM, Michael Niedermayer wrote: > > > > On Fri, Oct 11, 2019 at 08:51:54PM +110

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-14 Thread Michael Niedermayer
On Sun, Oct 13, 2019 at 10:51:49AM +1100, Peter Ross wrote: > On Sat, Oct 12, 2019 at 06:53:05PM -0300, James Almer wrote: > > On 10/12/2019 5:47 PM, Michael Niedermayer wrote: > > > On Fri, Oct 11, 2019 at 08:51:54PM +1100, Peter Ross wrote: > > >> On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-12 Thread Peter Ross
On Sat, Oct 12, 2019 at 06:53:05PM -0300, James Almer wrote: > On 10/12/2019 5:47 PM, Michael Niedermayer wrote: > > On Fri, Oct 11, 2019 at 08:51:54PM +1100, Peter Ross wrote: > >> On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote: > >>> Fixes: signed integer overflow: 1092624416

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-12 Thread James Almer
On 10/12/2019 5:47 PM, Michael Niedermayer wrote: > On Fri, Oct 11, 2019 at 08:51:54PM +1100, Peter Ross wrote: >> On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote: >>> Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in >>> type 'int' >>> Fixes: >>> 18045/c

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-12 Thread Michael Niedermayer
On Fri, Oct 11, 2019 at 08:51:54PM +1100, Peter Ross wrote: > On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in > > type 'int' > > Fixes: > > 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-11 Thread Peter Ross
On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in type > 'int' > Fixes: > 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_RDFT_fuzzer-5718519492116480 > > Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-11 Thread Paul B Mahol
lgtm On 10/11/19, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in type > 'int' > Fixes: > 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_RDFT_fuzzer-5718519492116480 > > Found-by: continuous fuzzing process > https://github.c

[FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-10 Thread Michael Niedermayer
Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in type 'int' Fixes: 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_RDFT_fuzzer-5718519492116480 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off