Re: [FFmpeg-devel] [PATCH 1/5] avformat/aviobuf: Don't check for overflow after it happened

2020-06-09 Thread Andreas Rheinhardt
Andreas Rheinhardt: > If adding two ints overflows, it doesn't matter whether the result will > be stored in an unsigned or not; and checking afterwards does not make it > retroactively defined. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aviobuf.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 1/5] avformat/aviobuf: Don't check for overflow after it happened

2020-05-25 Thread Andreas Rheinhardt
James Almer: > On 5/25/2020 11:07 AM, Andreas Rheinhardt wrote: >> If adding two ints overflows, it doesn't matter whether the result will >> be stored in an unsigned or not; and checking afterwards does not make it >> retroactively defined. >> >> Signed-off-by: Andreas Rheinhardt >> --- >>

Re: [FFmpeg-devel] [PATCH 1/5] avformat/aviobuf: Don't check for overflow after it happened

2020-05-25 Thread James Almer
On 5/25/2020 11:07 AM, Andreas Rheinhardt wrote: > If adding two ints overflows, it doesn't matter whether the result will > be stored in an unsigned or not; and checking afterwards does not make it > retroactively defined. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aviobuf.c | 2

[FFmpeg-devel] [PATCH 1/5] avformat/aviobuf: Don't check for overflow after it happened

2020-05-25 Thread Andreas Rheinhardt
If adding two ints overflows, it doesn't matter whether the result will be stored in an unsigned or not; and checking afterwards does not make it retroactively defined. Signed-off-by: Andreas Rheinhardt --- libavformat/aviobuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git