Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-08-01 Thread Clément Bœsch
On Sat, Jul 29, 2017 at 09:27:47PM +0200, Clément Bœsch wrote: > This commit switches off forced correct nesting of tags and only keeps > it for font tags. See long explanations in the code for the rationale. > > This results in various FATE changes which I'll explain here: > > - various

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread James Almer
On 7/30/2017 9:55 PM, Michael Niedermayer wrote: > On Sun, Jul 30, 2017 at 03:47:39PM -0300, James Almer wrote: >> On 7/30/2017 5:25 AM, Clément Bœsch wrote: >>> On Sun, Jul 30, 2017 at 04:34:16AM +0200, Michael Niedermayer wrote: >>> [...] > +struct font_tag stack[16] = {0};

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread Michael Niedermayer
On Sun, Jul 30, 2017 at 05:09:11PM +0200, Nicolas George wrote: > Le duodi 12 thermidor, an CCXXV, Michael Niedermayer a écrit : > > this is true for many warnings > > still warnings like this can "hide" real issues by one not seeing them > > in a wood of meaningless warnings. > > That is i think

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread Michael Niedermayer
On Sun, Jul 30, 2017 at 03:47:39PM -0300, James Almer wrote: > On 7/30/2017 5:25 AM, Clément Bœsch wrote: > > On Sun, Jul 30, 2017 at 04:34:16AM +0200, Michael Niedermayer wrote: > > [...] > >>> +struct font_tag stack[16] = {0}; > >> > >> this seems to produce a compiler warning: > >> > >>

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread James Almer
On 7/30/2017 5:25 AM, Clément Bœsch wrote: > On Sun, Jul 30, 2017 at 04:34:16AM +0200, Michael Niedermayer wrote: > [...] >>> +struct font_tag stack[16] = {0}; >> >> this seems to produce a compiler warning: >> >> ./libavcodec/htmlsubtitles.c: In function ‘ff_htmlmarkup_to_ass’: >>

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread Nicolas George
Le duodi 12 thermidor, an CCXXV, Michael Niedermayer a écrit : > this is true for many warnings > still warnings like this can "hide" real issues by one not seeing them > in a wood of meaningless warnings. > That is i think we should disable this type of warning or if we cant > then do the

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread Michael Niedermayer
On Sun, Jul 30, 2017 at 12:31:57PM +0200, Nicolas George wrote: > Le duodi 12 thermidor, an CCXXV, Michael Niedermayer a écrit : > > maybe but the compiler doesnt complain about them > > i think the difference is the number of nested {} > > Yes and no. This construct is valid, otherwise the gcc

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread Nicolas George
Le duodi 12 thermidor, an CCXXV, Michael Niedermayer a écrit : > maybe but the compiler doesnt complain about them > i think the difference is the number of nested {} Yes and no. This construct is valid, otherwise the gcc developers would not have removed the warning. The construct with the

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread Michael Niedermayer
On Sun, Jul 30, 2017 at 10:31:40AM +0200, Nicolas George wrote: > Le duodi 12 thermidor, an CCXXV, Clement Boesch a écrit : > > > ./libavcodec/htmlsubtitles.c: In function ‘ff_htmlmarkup_to_ass’: > > > ./libavcodec/htmlsubtitles.c:112:12: warning: missing braces around > > > initializer

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread Nicolas George
Le duodi 12 thermidor, an CCXXV, Clement Boesch a écrit : > > ./libavcodec/htmlsubtitles.c: In function ‘ff_htmlmarkup_to_ass’: > > ./libavcodec/htmlsubtitles.c:112:12: warning: missing braces around > > initializer [-Wmissing-braces] > Ah, I don't have that warning. IIRC it is an obsolete

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-30 Thread Clément Bœsch
On Sun, Jul 30, 2017 at 04:34:16AM +0200, Michael Niedermayer wrote: [...] > > +struct font_tag stack[16] = {0}; > > this seems to produce a compiler warning: > > ./libavcodec/htmlsubtitles.c: In function ‘ff_htmlmarkup_to_ass’: > ./libavcodec/htmlsubtitles.c:112:12: warning: missing braces

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-29 Thread Michael Niedermayer
On Sat, Jul 29, 2017 at 09:27:47PM +0200, Clément Bœsch wrote: > This commit switches off forced correct nesting of tags and only keeps > it for font tags. See long explanations in the code for the rationale. > > This results in various FATE changes which I'll explain here: > > - various

[FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

2017-07-29 Thread Clément Bœsch
This commit switches off forced correct nesting of tags and only keeps it for font tags. See long explanations in the code for the rationale. This results in various FATE changes which I'll explain here: - various swapping in font attributes, this is mostly noise due to the old reverse stack