Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Reimar Döffinger
On 14.03.2015, at 20:08, Christophe Gisquet wrote: > 2015-03-14 20:06 GMT+01:00 Michael Niedermayer : >>> So here's an updated patch. >> >> yes, but not in the email ;) > > Crap, I prepared the mail in advance, but forgot to attach the patch > after the fate run. I kind of object to making th

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 08:08:23PM +0100, Christophe Gisquet wrote: > 2015-03-14 20:06 GMT+01:00 Michael Niedermayer : > >> So here's an updated patch. > > > > yes, but not in the email ;) > > Crap, I prepared the mail in advance, but forgot to attach the patch > after the fate run. > > -- > Chr

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
2015-03-14 20:06 GMT+01:00 Michael Niedermayer : >> So here's an updated patch. > > yes, but not in the email ;) Crap, I prepared the mail in advance, but forgot to attach the patch after the fate run. -- Christophe From 46f45c02767dcba473197c2b633e3de69385f371 Mon Sep 17 00:00:00 2001 From: Chr

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 07:57:19PM +0100, Christophe Gisquet wrote: > Hi, > > 2015-03-14 18:38 GMT+01:00 Michael Niedermayer : > >> static void ff_prores_idct_wrap(int16_t *dst){ > >> -DECLARE_ALIGNED(16, static int16_t, qmat)[64]; > >> +LOCAL_ALIGNED(16, static int16_t, qmat, [64]); > >>

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
Hi, 2015-03-14 18:38 GMT+01:00 Michael Niedermayer : >> static void ff_prores_idct_wrap(int16_t *dst){ >> -DECLARE_ALIGNED(16, static int16_t, qmat)[64]; >> +LOCAL_ALIGNED(16, static int16_t, qmat, [64]); >> int i; > > this seems to break build > > ffmpeg/libavcodec/dct-test.c: In fu

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 03:30:24PM +, Christophe Gisquet wrote: > The later may yield incorrect code for on-stack variables. > --- > libavcodec/dct-test.c | 2 +- > libavcodec/h264_loopfilter.c| 10 +- > libavcodec/proresenc_anatoliy.c | 3 ++- > libavcodec/vp8.c

[FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
The later may yield incorrect code for on-stack variables. --- libavcodec/dct-test.c | 2 +- libavcodec/h264_loopfilter.c| 10 +- libavcodec/proresenc_anatoliy.c | 3 ++- libavcodec/vp8.c| 2 +- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a