Re: [FFmpeg-devel] [PATCH 1/6] bitstream_filter: add an init function

2014-11-30 Thread Christophe Gisquet
Hi, 2014-11-30 4:08 GMT+01:00 Michael Niedermayer michae...@gmx.at: this breaks ABI/API why is what is done in init not just done in the first packet when the args are already available ? This seems simpler and would avoid introducing a API that is possibly going to be deprecated once a

Re: [FFmpeg-devel] [PATCH 1/6] bitstream_filter: add an init function

2014-11-30 Thread Christophe Gisquet
2014-11-30 10:59 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: So I'm going to add a AVDictionary *bsf_args to OutputStream. That dictionary lookup seems negligible to the amount of work done overall. Done in the attached patch. I've edited the documentation also to reflect this

Re: [FFmpeg-devel] [PATCH 1/6] bitstream_filter: add an init function

2014-11-30 Thread Michael Niedermayer
On Sun, Nov 30, 2014 at 12:11:07PM +0100, Christophe Gisquet wrote: 2014-11-30 10:59 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: So I'm going to add a AVDictionary *bsf_args to OutputStream. That dictionary lookup seems negligible to the amount of work done overall. Done

Re: [FFmpeg-devel] [PATCH 1/6] bitstream_filter: add an init function

2014-11-29 Thread Michael Niedermayer
On Sun, Nov 30, 2014 at 12:45:51AM +, Christophe Gisquet wrote: From: Zongyi Zhou zho...@os.pku.edu.cn Original patch was adding an arg field in the context structure. As it is most often only useful once, allow passing the arguments on init. The proper solution would be using