Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2015-02-01 Thread Michael Niedermayer
On Sun, Feb 01, 2015 at 05:24:56PM -0500, Ronald S. Bultje wrote: > Hi, > > On Sun, Feb 1, 2015 at 4:26 PM, Christophe Gisquet < > christophe.gisq...@gmail.com> wrote: > > > 2014-09-05 9:59 GMT+02:00 Christophe Gisquet > >: > > > I haven't yet had time to investigate where the problem is. Probab

Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2015-02-01 Thread Ronald S. Bultje
Hi, On Sun, Feb 1, 2015 at 4:26 PM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > 2014-09-05 9:59 GMT+02:00 Christophe Gisquet >: > > I haven't yet had time to investigate where the problem is. Probably > PEBKAC > > It was PEBKAC. > > The patch was commited to x264 in August 2014:

Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2015-02-01 Thread Christophe Gisquet
2014-09-05 9:59 GMT+02:00 Christophe Gisquet : > I haven't yet had time to investigate where the problem is. Probably PEBKAC It was PEBKAC. The patch was commited to x264 in August 2014: https://github.com/MasterNobody/x264/commit/73b8686fc22c9247d90963983d406cd7b9131068 Could we merge it? --

Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2014-09-05 Thread Christophe Gisquet
Hi, Le 5 sept. 2014 00:14, "James Darnley" a écrit : I think I tested the same patch and for some reason it incorrectly flagged packusdw in a macro in this tree: https://github.com/kurosu/ffmpeg/tree/hevc_mt I haven't yet had time to investigate where the problem is. Probably PEBKAC as it had n

Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2014-09-04 Thread Michael Niedermayer
On Fri, Sep 05, 2014 at 12:49:10AM +0200, James Darnley wrote: > On 2014-09-05 00:13, James Darnley wrote: > > From: Anton Mitrofanov > > > > --- > > libavutil/x86/x86inc.asm | 581 > > +++--- > > 1 files changed, 295 insertions(+), 286 deletions(-) > >

Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2014-09-04 Thread James Darnley
On 2014-09-05 00:13, James Darnley wrote: > From: Anton Mitrofanov > > --- > libavutil/x86/x86inc.asm | 581 > +++--- > 1 files changed, 295 insertions(+), 286 deletions(-) If I didn't make it clear, this has not yet been added to x264's x86inc. It is

[FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2014-09-04 Thread James Darnley
From: Anton Mitrofanov --- libavutil/x86/x86inc.asm | 581 +++--- 1 files changed, 295 insertions(+), 286 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index 1cfb055..87f3af7 100644 --- a/libavutil/x86/x86inc.asm +++ b/lib