Re: [FFmpeg-devel] [PATCH 1/7] avcodec/indeo2: Remove #ifdef BITSTREAM_READER_LE cruft

2020-10-12 Thread Paul B Mahol
On Mon, Oct 12, 2020 at 10:12:11AM +0200, Andreas Rheinhardt wrote: > Before the LE bitstream reader was used in the Indeo 2 decoder, > a standard BE bitstream reader with swapped bits was used; when the LE > bitstream reader was added, the old code was only #ifdef'ed away and not > removed. Said c

[FFmpeg-devel] [PATCH 1/7] avcodec/indeo2: Remove #ifdef BITSTREAM_READER_LE cruft

2020-10-12 Thread Andreas Rheinhardt
Before the LE bitstream reader was used in the Indeo 2 decoder, a standard BE bitstream reader with swapped bits was used; when the LE bitstream reader was added, the old code was only #ifdef'ed away and not removed. Said code has several problems: It modifies the input packet without ensuring that