Re: [FFmpeg-devel] [PATCH 1/7] avcodec/mpc: Fix multiple numerical overflows in ff_mpc_dequantize_and_synth()

2020-05-10 Thread Michael Niedermayer
On Sun, May 10, 2020 at 09:20:13PM +0200, Michael Niedermayer wrote: > This uses lrintf() which is not ideal as it still can raise an error > but it is not undefined behavior. So a better solution should ideally be found > > Fixes: -2.4187e+09 is outside the range of representable values of type '

[FFmpeg-devel] [PATCH 1/7] avcodec/mpc: Fix multiple numerical overflows in ff_mpc_dequantize_and_synth()

2020-05-10 Thread Michael Niedermayer
This uses lrintf() which is not ideal as it still can raise an error but it is not undefined behavior. So a better solution should ideally be found Fixes: -2.4187e+09 is outside the range of representable values of type 'int' Fixes: signed integer overflow: -14512205 + -2147483648 cannot be repres