Re: [FFmpeg-devel] [PATCH 10/11] avformat/oggparsevorbis: Use AV_DICT_DONT_STRDUP_VAL to avoid av_strdup

2020-01-17 Thread Michael Niedermayer
On Mon, Nov 11, 2019 at 02:12:58AM +0100, Andreas Rheinhardt wrote: > This will likely also fix CID 1452427, a false positive resulting from > Coverity thinking that av_dict_set() automatically frees its key and > value parameters (even without the AV_DICT_DONT_STRDUP_* flags). > > (AV_DICT_APPEND

Re: [FFmpeg-devel] [PATCH 10/11] avformat/oggparsevorbis: Use AV_DICT_DONT_STRDUP_VAL to avoid av_strdup

2020-01-16 Thread Andreas Rheinhardt
On Mon, Nov 11, 2019 at 2:13 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > This will likely also fix CID 1452427, a false positive resulting from > Coverity thinking that av_dict_set() automatically frees its key and > value parameters (even without the AV_DICT_DONT_STRDUP_* flags

[FFmpeg-devel] [PATCH 10/11] avformat/oggparsevorbis: Use AV_DICT_DONT_STRDUP_VAL to avoid av_strdup

2019-11-10 Thread Andreas Rheinhardt
This will likely also fix CID 1452427, a false positive resulting from Coverity thinking that av_dict_set() automatically frees its key and value parameters (even without the AV_DICT_DONT_STRDUP_* flags). (AV_DICT_APPEND and AV_DICT_DONT_STRDUP_VAL are compatible with each other since a8c5b455, so