Re: [FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

2017-08-10 Thread Clément Bœsch
On Thu, Aug 10, 2017 at 11:33:31AM +0200, Nicolas George wrote: > Le tridi 23 thermidor, an CCXXV, Clement Boesch a écrit : > > But unless it's API documented, that's implementation specific. I'd prefer > > if you keep that as a safe guard. It also has a documentation purpose. > > I will do it if

Re: [FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

2017-08-10 Thread Nicolas George
Le tridi 23 thermidor, an CCXXV, Clement Boesch a écrit : > But unless it's API documented, that's implementation specific. I'd prefer > if you keep that as a safe guard. It also has a documentation purpose. I will do it if you insist, but before that, let me correct a little detail: > If the fra

Re: [FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

2017-08-10 Thread Clément Bœsch
On Thu, Aug 10, 2017 at 09:13:13AM +0200, Nicolas George wrote: > Le tridi 23 thermidor, an CCXXV, Clement Boesch a écrit : > > > -.needs_writable = 1, // for error diffusal dithering > > why? > > It was not needed in the first place: IIRC, dualinput always returns a > writable main frame.

Re: [FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

2017-08-10 Thread Nicolas George
Le tridi 23 thermidor, an CCXXV, Clement Boesch a écrit : > > -.needs_writable = 1, // for error diffusal dithering > why? It was not needed in the first place: IIRC, dualinput always returns a writable main frame. And the new implementation does, I am sure of it. Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

2017-08-09 Thread Clément Bœsch
On Mon, Jul 31, 2017 at 02:02:24PM +0200, Nicolas George wrote: [...] > @@ -1052,13 +1070,10 @@ static const AVFilterPad paletteuse_inputs[] = { > { > .name = "default", > .type = AVMEDIA_TYPE_VIDEO, > -.filter_frame = filter_frame, > -.

[FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile| 2 +- libavfilter/vf_paletteuse.c | 59 - 2 files changed, 38 insertions(+), 23 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index a62339992f..4e4201e2b6 100644 -