Re: [FFmpeg-devel] [PATCH 12/12] cbs_h264, h264_metadata: Deleting SEI messages never fails

2019-07-08 Thread Mark Thompson
On 08/07/2019 00:14, Andreas Rheinhardt wrote: > ff_cbs_delete_unit never fails if the index of the unit to delete is > valid, as it is with all current callers of the function. So just assert > in ff_cbs_delete_unit that the index is valid and change the return > value to void in order to remove

[FFmpeg-devel] [PATCH 12/12] cbs_h264, h264_metadata: Deleting SEI messages never fails

2019-07-07 Thread Andreas Rheinhardt
Given the recent changes to ff_cbs_delete_unit, it is no longer sensible to use a return value for ff_cbs_h264_delete_sei_message; instead, use asserts to ensure that the required conditions are met and remove the callers' checks for the return value. Also, document said conditions. An assert