Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread James Almer
On 5/14/2021 5:28 PM, Anton Khirnov wrote: Quoting James Almer (2021-05-14 14:42:10) On 5/14/2021 5:01 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-05-10 16:06:01) On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: There are no guarantees that all side data types hav

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread Anton Khirnov
Quoting James Almer (2021-05-14 14:42:10) > On 5/14/2021 5:01 AM, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-05-10 16:06:01) > >> On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: > >>> There are no guarantees that all side data types have the same > >>> representation

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread Andreas Rheinhardt
James Almer: > On 5/14/2021 3:16 PM, Michael Niedermayer wrote: >> On Fri, May 14, 2021 at 09:42:10AM -0300, James Almer wrote: >>> On 5/14/2021 5:01 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-05-10 16:06:01) > On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote:

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread James Almer
On 5/14/2021 3:16 PM, Michael Niedermayer wrote: On Fri, May 14, 2021 at 09:42:10AM -0300, James Almer wrote: On 5/14/2021 5:01 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-05-10 16:06:01) On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: There are no guarantees tha

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread Michael Niedermayer
On Fri, May 14, 2021 at 09:42:10AM -0300, James Almer wrote: > On 5/14/2021 5:01 AM, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-05-10 16:06:01) > > > On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: > > > > There are no guarantees that all side data types have the same

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread James Almer
On 5/14/2021 5:01 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-05-10 16:06:01) On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: There are no guarantees that all side data types have the same representation on all platforms. @@ -65,63 +51,6 @@ static int framecrc_w

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-05-10 16:06:01) > On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: > > There are no guarantees that all side data types have the same > > representation on all platforms. > > > @@ -65,63 +51,6 @@ static int framecrc_write_packet(struct AVFormatContex

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-10 Thread Michael Niedermayer
On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: > There are no guarantees that all side data types have the same > representation on all platforms. > @@ -65,63 +51,6 @@ static int framecrc_write_packet(struct AVFormatContext > *s, AVPacket *pkt) > pkt->stream_index, p

[FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-04-25 Thread Anton Khirnov
There are no guarantees that all side data types have the same representation on all platforms. Tests that change output due to this: id3v2-priv-remux, cover-art-mp3-id3v2-remux, gapless-mp3: SKIP_SAMPLES, which is tested by fate-gapless-mp3-side-data matroska-vp8-alpha-remux: MATROSKA_BLOCKADDI