Re: [FFmpeg-devel] [PATCH 15/26] vaapi_encode: Clean up rate control configuration

2018-04-27 Thread Mark Thompson
On 27/04/18 05:10, Xiang, Haihao wrote: > On Sun, 2018-04-22 at 16:29 +0100, Mark Thompson wrote: >> Query which modes are supported and select between VBR and CBR based >> on that. Removes all of the codec-specific rate control mode selection >> code. Also ensures that target percentage and

Re: [FFmpeg-devel] [PATCH 15/26] vaapi_encode: Clean up rate control configuration

2018-04-26 Thread Xiang, Haihao
On Sun, 2018-04-22 at 16:29 +0100, Mark Thompson wrote: > Query which modes are supported and select between VBR and CBR based > on that. Removes all of the codec-specific rate control mode selection > code. Also ensures that target percentage and window size match the > target bitrate and RC

[FFmpeg-devel] [PATCH 15/26] vaapi_encode: Clean up rate control configuration

2018-04-22 Thread Mark Thompson
Query which modes are supported and select between VBR and CBR based on that. Removes all of the codec-specific rate control mode selection code. Also ensures that target percentage and window size match the target bitrate and RC buffer size in all cases where they are not explicitly specified.