Re: [FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

2017-01-08 Thread Nicolas George
Le nonidi 9 nivôse, an CCXXV, Nicolas George a écrit : > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.c | 214 > +-- > 1 file changed, 56 insertions(+), 158 deletions(-) > > Minor changes to accomodate the previous changes. Since diff

Re: [FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

2017-01-08 Thread Nicolas George
Le nonidi 19 nivôse, an CCXXV, Rostislav Pehlivanov a écrit : > I think it might be related to this infinite loop issue: > > ffmpeg -i fT7.wav -af dynaudnorm -loglevel error -f null - > > with the file I've attached will get stuck in an infinite loop outside of > the filter somewhere. Thanks for

Re: [FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

2017-01-05 Thread Nicolas George
Le sextidi 16 nivôse, an CCXXV, Rostislav Pehlivanov a écrit : > Thanks, the excerpt looks fine to me. Thanks for the review. One to go. > btw, there's apparently been a regression w.r.t. EOF handling which wm4 > hasn't told you about yet, not sure which commit introduced it though: > > https://

Re: [FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

2017-01-05 Thread Rostislav Pehlivanov
On 5 January 2017 at 10:27, Nicolas George wrote: > Le nonidi 9 nivôse, an CCXXV, Nicolas George a écrit : > > Signed-off-by: Nicolas George > > --- > > libavfilter/buffersink.c | 214 +- > - > > 1 file changed, 56 insertions(+), 158 deletions(-) > >

Re: [FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

2017-01-05 Thread Nicolas George
Le nonidi 9 nivôse, an CCXXV, Nicolas George a écrit : > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.c | 214 > +-- > 1 file changed, 56 insertions(+), 158 deletions(-) > > > Minor changes to accomodate the previous changes. Since di

[FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

2016-12-29 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/buffersink.c | 214 +-- 1 file changed, 56 insertions(+), 158 deletions(-) Minor changes to accomodate the previous changes. Since diff is not very smart about it, better read the code than the patch. di

Re: [FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

2016-12-24 Thread Nicolas George
Le quintidi 5 nivôse, an CCXXV, Michael Niedermayer a écrit : > On Sat, Dec 24, 2016 at 06:41:49PM +0100, Nicolas George wrote: > > Signed-off-by: Nicolas George > > --- > > libavfilter/buffersink.c | 211 > > --- > > 1 file changed, 54 insertions(+),

Re: [FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

2016-12-24 Thread Michael Niedermayer
On Sat, Dec 24, 2016 at 06:41:49PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.c | 211 > --- > 1 file changed, 54 insertions(+), 157 deletions(-) this seems not applying cleanly here Applying: lavfi/bu

[FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

2016-12-24 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/buffersink.c | 211 --- 1 file changed, 54 insertions(+), 157 deletions(-) Hum, it seems diff is not making it easy to see what functions are changed, deleted or added. return_or_keep_frame() is a small h