Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-23 Thread Hendrik Leppkes
On Fri, Feb 23, 2018 at 11:47 AM, Nicolas George wrote: > >> - dynamic loading alone has some pros (e.g. not needing the SDK >>on every machine where you use your built ffmpeg) > > Sorry, you are wrong, this is not how dynamic loading works. You need > the shared library

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-23 Thread Ricardo Constantino
On 22 February 2018 at 22:53, Marton Balint wrote: > > > On Thu, 22 Feb 2018, Ricardo Constantino wrote: > > On 22 February 2018 at 22:22, Carl Eugen Hoyos wrote: >> >> 2018-02-22 20:26 GMT+01:00 Marton Balint : >>> > >>> > On Wed, 21 Feb

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-23 Thread Nicolas George
Marton Balint (2018-02-23): > The environment variable contains the directory to the library, not the > library name itself. So it reinvents LD_LIBRARY_PATH. Probably badly. > LD_LIBRARY_PATH, LD_PRELOAD is an environment variable as well, so I don't > see why it is different from security

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-22 Thread Marton Balint
On Thu, 22 Feb 2018, Nicolas George wrote: Marton Balint (2018-02-22): I think what CE ment was static v.s. dynamic lib names I am pretty sure he asked if the file name of the library could be different at run time than at compile time, which would be the only reason to justify using an

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-22 Thread Carl Eugen Hoyos
2018-02-22 23:57 GMT+01:00 Nicolas George : > Marton Balint (2018-02-22): >> I think what CE ment was static v.s. dynamic lib names > > I am pretty sure he asked if the file name of the library could be > different at run time than at compile time, which would be the only > reason

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-22 Thread Nicolas George
Marton Balint (2018-02-22): > I think what CE ment was static v.s. dynamic lib names I am pretty sure he asked if the file name of the library could be different at run time than at compile time, which would be the only reason to justify using an environment variable. By the way, using an

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-22 Thread Marton Balint
On Thu, 22 Feb 2018, Ricardo Constantino wrote: On 22 February 2018 at 22:22, Carl Eugen Hoyos wrote: 2018-02-22 20:26 GMT+01:00 Marton Balint : > > On Wed, 21 Feb 2018, Nicolas George wrote: > >> Marton Balint (2018-02-20): >>> >>> The patch might has

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-22 Thread Marton Balint
On Thu, 22 Feb 2018, Carl Eugen Hoyos wrote: 2018-02-22 20:26 GMT+01:00 Marton Balint : On Wed, 21 Feb 2018, Nicolas George wrote: Marton Balint (2018-02-20): The patch might has merits even if the library remains in the NONFREE section, no? I see more code and easier

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-22 Thread Ricardo Constantino
On 22 February 2018 at 22:22, Carl Eugen Hoyos wrote: > 2018-02-22 20:26 GMT+01:00 Marton Balint : > > > > On Wed, 21 Feb 2018, Nicolas George wrote: > > > >> Marton Balint (2018-02-20): > >>> > >>> The patch might has merits even if the library remains in the

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-22 Thread Carl Eugen Hoyos
2018-02-22 20:26 GMT+01:00 Marton Balint : > > On Wed, 21 Feb 2018, Nicolas George wrote: > >> Marton Balint (2018-02-20): >>> >>> The patch might has merits even if the library remains in the NONFREE >>> section, no? >> >> I see more code and easier circumvention of the GPL, but

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-22 Thread Marton Balint
On Wed, 21 Feb 2018, Nicolas George wrote: Marton Balint (2018-02-20): The patch might has merits even if the library remains in the NONFREE section, no? I see more code and easier circumvention of the GPL, but no merit. Please be more specific. I guess the biggest advantage of dynamic

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-21 Thread Nicolas George
Marton Balint (2018-02-20): > The patch might has merits even if the library remains in the NONFREE > section, no? I see more code and easier circumvention of the GPL, but no merit. Please be more specific. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-21 Thread Marton Balint
On Wed, 21 Feb 2018, Maksym Veremeyenko wrote: 21.02.2018 0:39, Carl Eugen Hoyos пише: 2018-02-20 23:35 GMT+01:00 Marton Balint : On Tue, 20 Feb 2018, Carl Eugen Hoyos wrote: 2018-02-20 17:32 GMT+01:00 Maksym Veremeyenko : attached patch implement

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Maksym Veremeyenko
21.02.2018 0:39, Carl Eugen Hoyos пише: 2018-02-20 23:35 GMT+01:00 Marton Balint : On Tue, 20 Feb 2018, Carl Eugen Hoyos wrote: 2018-02-20 17:32 GMT+01:00 Maksym Veremeyenko : attached patch implement dynamic loading of NewTek library and drop

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Carl Eugen Hoyos
2018-02-20 23:35 GMT+01:00 Marton Balint : > > On Tue, 20 Feb 2018, Carl Eugen Hoyos wrote: > >> 2018-02-20 17:32 GMT+01:00 Maksym Veremeyenko : >> >>> attached patch implement dynamic loading of NewTek library and >>> drop dependencies from NewTek SDK (if

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Marton Balint
On Tue, 20 Feb 2018, Carl Eugen Hoyos wrote: 2018-02-20 17:32 GMT+01:00 Maksym Veremeyenko : attached patch implement dynamic loading of NewTek library and drop dependencies from NewTek SDK (if previous patch with including headers applied) This patch is not ok assuming

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Carl Eugen Hoyos
2018-02-20 17:32 GMT+01:00 Maksym Veremeyenko : > attached patch implement dynamic loading of NewTek library and > drop dependencies from NewTek SDK (if previous patch with > including headers applied) This patch is not ok assuming the runtime library is not open source and

[FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Maksym Veremeyenko
Hi attached patch implement dynamic loading of NewTek library and drop dependencies from NewTek SDK (if previous patch with including headers applied) please review/comment/apply -- Maksym Veremeyenko From 8c0337878bdb8a1ccbc56ede42686e2a4d8e882e Mon Sep 17 00:00:00 2001 From: Maksym