Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

2020-06-16 Thread Michael Niedermayer
On Tue, Jun 16, 2020 at 02:05:04PM +0200, Tomas Härdin wrote: > mån 2020-06-15 klockan 21:45 +0200 skrev Marton Balint: > > > > On Mon, 15 Jun 2020, Tomas Härdin wrote: > > > > > sön 2020-06-14 klockan 20:19 +0200 skrev Marton Balint: > > > > On Sun, 14 Jun 2020, Michael Niedermayer wrote: > > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

2020-06-16 Thread Tomas Härdin
mån 2020-06-15 klockan 21:45 +0200 skrev Marton Balint: > > On Mon, 15 Jun 2020, Tomas Härdin wrote: > > > sön 2020-06-14 klockan 20:19 +0200 skrev Marton Balint: > > > On Sun, 14 Jun 2020, Michael Niedermayer wrote: > > > > > > > Alternatively we could free the already allocated element > > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

2020-06-15 Thread Marton Balint
On Mon, 15 Jun 2020, Tomas Härdin wrote: sön 2020-06-14 klockan 20:19 +0200 skrev Marton Balint: On Sun, 14 Jun 2020, Michael Niedermayer wrote: > Alternatively we could free the already allocated element Yeah, I kind of prefer that, we potentially allow non-string values to occur multipl

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

2020-06-15 Thread Tomas Härdin
sön 2020-06-14 klockan 20:19 +0200 skrev Marton Balint: > > On Sun, 14 Jun 2020, Michael Niedermayer wrote: > > > Alternatively we could free the already allocated element > > Yeah, I kind of prefer that, we potentially allow non-string values to > occur multiple times, so I'd say let's allow s

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

2020-06-14 Thread Michael Niedermayer
On Sun, Jun 14, 2020 at 08:19:18PM +0200, Marton Balint wrote: > > > On Sun, 14 Jun 2020, Michael Niedermayer wrote: > > > Alternatively we could free the already allocated element > > Yeah, I kind of prefer that, we potentially allow non-string values to occur > multiple times, so I'd say let'

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

2020-06-14 Thread Marton Balint
On Sun, 14 Jun 2020, Michael Niedermayer wrote: Alternatively we could free the already allocated element Yeah, I kind of prefer that, we potentially allow non-string values to occur multiple times, so I'd say let's allow string values as well, even if that is not common. (I am not sure if

[FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

2020-06-14 Thread Michael Niedermayer
Alternatively we could free the already allocated element Fixes: memleak Fixes: 23415/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5124814510751744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---