Re: [FFmpeg-devel] [PATCH 2/2] avformat/utils: Fix memleaks

2019-09-25 Thread James Almer
On 9/24/2019 1:31 PM, Andreas Rheinhardt wrote: > ff_read_packet had potential memleaks: > 1. If av_packet_make_refcounted fails, it means that the packet is not > refcounted, but it could nevertheless carry side data and therefore > needs to be unreferenced. > 2. If putting a packet on a packet

[FFmpeg-devel] [PATCH 2/2] avformat/utils: Fix memleaks

2019-09-24 Thread Andreas Rheinhardt
ff_read_packet had potential memleaks: 1. If av_packet_make_refcounted fails, it means that the packet is not refcounted, but it could nevertheless carry side data and therefore needs to be unreferenced. 2. If putting a packet on a packet list fails, it wasn't unreferenced. Furthermore,