Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-06 Thread Nicolas George
Anton Khirnov (12020-10-06): > Would you please stop with spamming this propaganda in unrelated topics? > Merging the libraries is your personal opinion, not "the only way > forward". Nobody, including you, has been able to express one practical benefit of having separate libraries that could not

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-06 Thread Anton Khirnov
Quoting Nicolas George (2020-10-05 12:53:44) > Nachiket Tarate (12020-10-05): > > What is your opinion about Anton Khirnov 's review > > comments ? > > The only way forward is to merge the libraries. The split of shared > objects brings all kinds of issues, including the problem of avpriv >

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-05 Thread James Almer
On 10/5/2020 7:48 AM, Nachiket Tarate wrote: > > > > From: ffmpeg-devel on behalf of Anton > Khirnov > Sent: Monday, October 5, 2020 1:50 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-05 Thread Nicolas George
Nachiket Tarate (12020-10-05): > What is your opinion about Anton Khirnov 's review > comments ? The only way forward is to merge the libraries. The split of shared objects brings all kinds of issues, including the problem of avpriv symbols, and no practical benefit. Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-05 Thread Nachiket Tarate
From: ffmpeg-devel on behalf of Anton Khirnov Sent: Monday, October 5, 2020 1:50 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-05 Thread Anton Khirnov
Quoting Nachiket Tarate (2020-10-04 16:35:09) > This will be used by HLS demuxer to parse EC3SpecificBox (dec3) during > SAMPLE-AES decryption. > > Signed-off-by: Nachiket Tarate Since the table is so small, it seems preferable to duplicate it in libavformat than add eat another private

[FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-04 Thread Nachiket Tarate
This will be used by HLS demuxer to parse EC3SpecificBox (dec3) during SAMPLE-AES decryption. Signed-off-by: Nachiket Tarate --- libavcodec/ac3_parser.c | 6 +++--- libavcodec/ac3enc.c | 2 +- libavcodec/ac3enc_fixed.c | 2 +- libavcodec/ac3enc_float.c | 2 +- libavcodec/ac3tab.c

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-04 Thread James Almer
On 10/4/2020 11:35 AM, Nachiket Tarate wrote: > This will be used by HLS demuxer to parse EC3SpecificBox (dec3) during > SAMPLE-AES decryption. > > Signed-off-by: Nachiket Tarate > --- > libavcodec/ac3_parser.c | 6 +++--- > libavcodec/ac3enc.c | 2 +- > libavcodec/ac3enc_fixed.c | 2

[FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-04 Thread Nachiket Tarate
This will be used by HLS demuxer to parse EC3SpecificBox (dec3) during SAMPLE-AES decryption. Signed-off-by: Nachiket Tarate --- libavcodec/ac3_parser.c | 6 +++--- libavcodec/ac3enc.c | 2 +- libavcodec/ac3enc_fixed.c | 2 +- libavcodec/ac3enc_float.c | 2 +- libavcodec/ac3tab.c