Re: [FFmpeg-devel] [PATCH 2/2] report.cgi: Clean chars in time and slot

2021-08-08 Thread Michael Niedermayer
On Sun, Aug 08, 2021 at 01:00:30PM +0100, Derek Buitenhuis wrote: > On 8/8/2021 9:28 AM, Michael Niedermayer wrote: > > +$req_slot =~ s/[^-._A-Za-z0-9 ]*//g; > > I don't think it is wise to allow periods here, considering > we use string ops to append it to a dir name just below. Periods are used

Re: [FFmpeg-devel] [PATCH 2/2] report.cgi: Clean chars in time and slot

2021-08-08 Thread Derek Buitenhuis
On 8/8/2021 9:28 AM, Michael Niedermayer wrote: > +$req_slot =~ s/[^-._A-Za-z0-9 ]*//g; I don't think it is wise to allow periods here, considering we use string ops to append it to a dir name just below. .. and we probably should not be using string ops to construct directory names. > +$req_tim

[FFmpeg-devel] [PATCH 2/2] report.cgi: Clean chars in time and slot

2021-08-08 Thread Michael Niedermayer
based on a39e4d1bee74647f534589b09eaf15246359d6b6 Signed-off-by: Michael Niedermayer --- report.cgi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/report.cgi b/report.cgi index 43ea134..5c457ac 100755 --- a/report.cgi +++ b/report.cgi @@ -25,6 +25,8 @@ use FATE; my $req_slot = param 's