Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacenc_is: Assert that minthr is not 0.0, this would lead to division by 0 later

2016-05-18 Thread Claudio Freire
On Mon, May 16, 2016 at 4:10 PM, Michael Niedermayer wrote: > yes, > > with the patch fate fails: > > Test aac-pred-encode failed. Look at tests/data/fate/aac-pred-encode.err for > details. > make: *** [fate-aac-pred-encode] Error 134 > > >> >> A threshold of 0 would in theory cause a zeroed band

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacenc_is: Assert that minthr is not 0.0, this would lead to division by 0 later

2016-05-16 Thread Michael Niedermayer
On Mon, May 16, 2016 at 01:33:37PM -0300, Claudio Freire wrote: > On Mon, May 16, 2016 at 12:26 PM, Kieran Kunhya wrote: > >> Testcase is fate-aac-pred-encode > >> > >> Signed-off-by: Michael Niedermayer > >> --- > >> libavcodec/aacenc_is.c |3 +++ > >> 1 file changed, 3 insertions(+) > >> >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacenc_is: Assert that minthr is not 0.0, this would lead to division by 0 later

2016-05-16 Thread Claudio Freire
On Mon, May 16, 2016 at 12:26 PM, Kieran Kunhya wrote: >> Testcase is fate-aac-pred-encode >> >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/aacenc_is.c |3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/aacenc_is.c b/libavcodec/aacenc_is.c >> index 473897b.

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacenc_is: Assert that minthr is not 0.0, this would lead to division by 0 later

2016-05-16 Thread Kieran Kunhya
On Mon, 16 May 2016 at 13:26 Michael Niedermayer wrote: > Testcase is fate-aac-pred-encode > > Signed-off-by: Michael Niedermayer > --- > libavcodec/aacenc_is.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/aacenc_is.c b/libavcodec/aacenc_is.c > index 473897b..e5cfa1

[FFmpeg-devel] [PATCH 2/3] avcodec/aacenc_is: Assert that minthr is not 0.0, this would lead to division by 0 later

2016-05-16 Thread Michael Niedermayer
Testcase is fate-aac-pred-encode Signed-off-by: Michael Niedermayer --- libavcodec/aacenc_is.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/aacenc_is.c b/libavcodec/aacenc_is.c index 473897b..e5cfa14 100644 --- a/libavcodec/aacenc_is.c +++ b/libavcodec/aacenc_is.c @@ -64,