Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

Le nonidi 19 ventôse, an CCXXV, Michael Niedermayer a écrit : > yes, i was trying to clarify a reply that was apparently unclear and > not understood. > its like > statement -> point out disagreement -> do not understand -> clarify > and > clarify -> "You are rehashing a lot of obvious facts" > >

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Thu, Mar 09, 2017 at 12:16:09PM +0100, Nicolas George wrote: > Le nonidi 19 ventôse, an CCXXV, Michael Niedermayer a écrit : > > This is very basic really but lets elaborate > > for each side data type T > > possiblity A > > nothing uses side data type T > > > > possiblity B > > something uses

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Thu, 9 Mar 2017 12:16:09 +0100 Nicolas George wrote: > Now, please answer this very specific question: > > If someone were to REMOVE ALL AND EVERY use of > av_packet_merge_side_data() and av_packet_split_side_data(), what would > be the actual bad consequences? Simply that

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Thu, 9 Mar 2017 12:00:38 +0100 Michael Niedermayer wrote: > On Thu, Mar 09, 2017 at 07:50:14AM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 23:34:39 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 09:01:32PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

Le nonidi 19 ventôse, an CCXXV, Michael Niedermayer a écrit : > This is very basic really but lets elaborate > for each side data type T > possiblity A > nothing uses side data type T > > possiblity B > something uses side data type T > > Its the same with a codec, either a codec is used in some

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Thu, Mar 09, 2017 at 07:50:14AM +0100, wm4 wrote: > On Wed, 8 Mar 2017 23:34:39 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 09:01:32PM +0100, wm4 wrote: > > > On Wed, 8 Mar 2017 20:54:43 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 23:34:39 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 09:01:32PM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 20:54:43 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 07:32:26PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, Mar 08, 2017 at 09:01:32PM +0100, wm4 wrote: > On Wed, 8 Mar 2017 20:54:43 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 07:32:26PM +0100, wm4 wrote: > > > On Wed, 8 Mar 2017 19:20:15 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 20:54:43 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 07:32:26PM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 19:20:15 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 20:42:17 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 08:23:26PM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 20:15:24 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 07:35:50PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, Mar 08, 2017 at 07:32:26PM +0100, wm4 wrote: > On Wed, 8 Mar 2017 19:20:15 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote: > > > On Wed, 8 Mar 2017 17:11:12 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, Mar 08, 2017 at 08:23:26PM +0100, wm4 wrote: > On Wed, 8 Mar 2017 20:15:24 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 07:35:50PM +0100, wm4 wrote: > > > On Wed, 8 Mar 2017 19:20:15 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 20:15:24 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 07:35:50PM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 19:20:15 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 19:56:42 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 07:31:27PM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 19:03:21 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, Mar 08, 2017 at 07:35:50PM +0100, wm4 wrote: > On Wed, 8 Mar 2017 19:20:15 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote: > > > On Wed, 8 Mar 2017 17:11:12 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, Mar 08, 2017 at 07:31:27PM +0100, wm4 wrote: > On Wed, 8 Mar 2017 19:03:21 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote: > > > On Wed, 8 Mar 2017 17:11:12 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On 3/8/2017 3:35 PM, wm4 wrote: > On Wed, 8 Mar 2017 19:20:15 +0100 > Michael Niedermayer wrote: > >> On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote: >>> On Wed, 8 Mar 2017 17:11:12 +0100 >>> Michael Niedermayer wrote: >>> On Wed, Mar

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 19:20:15 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 17:11:12 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 04:06:20PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 19:20:15 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 17:11:12 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 04:06:20PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 19:03:21 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 17:11:12 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 04:06:20PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote: > On Wed, 8 Mar 2017 17:11:12 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 04:06:20PM +0100, wm4 wrote: > > > On Wed, 8 Mar 2017 15:36:25 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote: > On Wed, 8 Mar 2017 17:11:12 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 04:06:20PM +0100, wm4 wrote: > > > On Wed, 8 Mar 2017 15:36:25 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 17:11:12 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 04:06:20PM +0100, wm4 wrote: > > On Wed, 8 Mar 2017 15:36:25 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 08, 2017 at 01:40:11PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, Mar 08, 2017 at 04:06:20PM +0100, wm4 wrote: > On Wed, 8 Mar 2017 15:36:25 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 01:40:11PM +0100, wm4 wrote: > > > It looks like this could lead to security issues, as side data readers [...] > > also

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, 8 Mar 2017 15:36:25 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 01:40:11PM +0100, wm4 wrote: > > It looks like this could lead to security issues, as side data readers > > anything could, but side data wasnt excluded from fuzzing, in fact > ive

Re: [FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

On Wed, Mar 08, 2017 at 01:40:11PM +0100, wm4 wrote: > It looks like this could lead to security issues, as side data readers anything could, but side data wasnt excluded from fuzzing, in fact ive seen fuzzers find and trigger the split code also a demuxer and user app could always set side data

[FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

It looks like this could lead to security issues, as side data readers will for example rely on side data allocation sizes to be as large as needed for correct operation. If such files exist at all, they also should be brought out of circulation, so fully reject them. Under normal circumstances,