Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

On Tue, Nov 22, 2016 at 11:06:49PM +0100, Andreas Cadhalpun wrote: > On 22.11.2016 12:06, Michael Niedermayer wrote: > > On Tue, Nov 22, 2016 at 12:29:02AM +0100, Andreas Cadhalpun wrote: > >> OK. Now I've another question. Why does the check involve o->max? > >> Is the out-of-range check at the

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

On 22.11.2016 12:06, Michael Niedermayer wrote: > On Tue, Nov 22, 2016 at 12:29:02AM +0100, Andreas Cadhalpun wrote: >> OK. Now I've another question. Why does the check involve o->max? >> Is the out-of-range check at the beginning of write_number not >> sufficient? > > removed, this too came

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

On Tue, Nov 22, 2016 at 12:29:02AM +0100, Andreas Cadhalpun wrote: > On 20.11.2016 21:52, Michael Niedermayer wrote: > > On Sun, Nov 20, 2016 at 08:55:44PM +0100, Andreas Cadhalpun wrote: > >> On 20.11.2016 12:57, Michael Niedermayer wrote: > >>> +if (intnum == 1 && d ==

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

On 20.11.2016 21:52, Michael Niedermayer wrote: > On Sun, Nov 20, 2016 at 08:55:44PM +0100, Andreas Cadhalpun wrote: >> On 20.11.2016 12:57, Michael Niedermayer wrote: >>> +if (intnum == 1 && d == (double)UINT64_MAX) { >>> +*(int64_t *)dst = UINT64_MAX; >> >> Is there a reason

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

On Sun, Nov 20, 2016 at 08:55:44PM +0100, Andreas Cadhalpun wrote: > On 20.11.2016 12:57, Michael Niedermayer wrote: > > Requested-by: wm4 ([FFmpeg-devel] [PATCH] avutil/opt: Support max > > > INT64_MAX in write_number() with AV_OPT_TYPE_INT64) > > Requested-by: ronald ([FFmpeg-devel] [PATCH]

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

On 20.11.2016 12:57, Michael Niedermayer wrote: > Requested-by: wm4 ([FFmpeg-devel] [PATCH] avutil/opt: Support max > INT64_MAX > in write_number() with AV_OPT_TYPE_INT64) > Requested-by: ronald ([FFmpeg-devel] [PATCH] avutil/opt: Support max > > INT64_MAX in write_number() with

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

On Sun, Nov 20, 2016 at 12:00:49PM -0500, Ronald S. Bultje wrote: > Hi, > > On Sun, Nov 20, 2016 at 9:16 AM, Michael Niedermayer > wrote: > > > On Sun, Nov 20, 2016 at 08:56:15AM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Sun, Nov 20, 2016 at 6:57 AM,

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

Hi, On Sun, Nov 20, 2016 at 9:16 AM, Michael Niedermayer wrote: > On Sun, Nov 20, 2016 at 08:56:15AM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Nov 20, 2016 at 6:57 AM, Michael Niedermayer > > > wrote: > > > > > @@ -131,6 +132,20 @@

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

On Sun, Nov 20, 2016 at 08:56:15AM -0500, Ronald S. Bultje wrote: > Hi, > > On Sun, Nov 20, 2016 at 6:57 AM, Michael Niedermayer > wrote: > > > @@ -131,6 +132,20 @@ static int write_number(void *obj, const AVOption *o, > > void *dst, double num, int > > if

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

Hi, On Sun, Nov 20, 2016 at 6:57 AM, Michael Niedermayer wrote: > @@ -131,6 +132,20 @@ static int write_number(void *obj, const AVOption *o, > void *dst, double num, int > if (intnum == 1 && d == (double)INT64_MAX) *(int64_t *)dst = > INT64_MAX; > else

[FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

Requested-by: wm4 ([FFmpeg-devel] [PATCH] avutil/opt: Support max > INT64_MAX in write_number() with AV_OPT_TYPE_INT64) Requested-by: ronald ([FFmpeg-devel] [PATCH] avutil/opt: Support max > INT64_MAX in write_number() with AV_OPT_TYPE_INT64) Signed-off-by: Michael Niedermayer