[FFmpeg-devel] [PATCH 2/3] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-07-20 Thread Marton Balint
50/60 fps timecode is using the field bit (which is the same as the phase correction bit) to signal the least significant bit of a 50/60 fps timecode. See SMPTE ST 12-1:2014 section 12.1. Let's add support for this by using the recently added av_timecode_get_smpte function which handles this prope

Re: [FFmpeg-devel] [PATCH 2/3] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-07-20 Thread lance . lmwang
On Mon, Jul 20, 2020 at 11:04:38PM +0200, Marton Balint wrote: > 50/60 fps timecode is using the field bit (which is the same as the phase > correction bit) to signal the least significant bit of a 50/60 fps timecode. > See SMPTE ST 12-1:2014 section 12.1. > > Let's add support for this by using t

Re: [FFmpeg-devel] [PATCH 2/3] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-07-21 Thread Marton Balint
On Tue, 21 Jul 2020, lance.lmw...@gmail.com wrote: On Mon, Jul 20, 2020 at 11:04:38PM +0200, Marton Balint wrote: 50/60 fps timecode is using the field bit (which is the same as the phase correction bit) to signal the least significant bit of a 50/60 fps timecode. See SMPTE ST 12-1:2014 secti

Re: [FFmpeg-devel] [PATCH 2/3] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-07-21 Thread lance . lmwang
On Tue, Jul 21, 2020 at 11:07:29AM +0200, Marton Balint wrote: > > > On Tue, 21 Jul 2020, lance.lmw...@gmail.com wrote: > > > On Mon, Jul 20, 2020 at 11:04:38PM +0200, Marton Balint wrote: > > > 50/60 fps timecode is using the field bit (which is the same as the phase > > > correction bit) to si

Re: [FFmpeg-devel] [PATCH 2/3] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-07-21 Thread Marton Balint
On Tue, 21 Jul 2020, lance.lmw...@gmail.com wrote: On Tue, Jul 21, 2020 at 11:07:29AM +0200, Marton Balint wrote: On Tue, 21 Jul 2020, lance.lmw...@gmail.com wrote: > On Mon, Jul 20, 2020 at 11:04:38PM +0200, Marton Balint wrote: > > 50/60 fps timecode is using the field bit (which is the

Re: [FFmpeg-devel] [PATCH 2/3] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-07-21 Thread lance . lmwang
On Tue, Jul 21, 2020 at 12:42:03PM +0200, Marton Balint wrote: > > > On Tue, 21 Jul 2020, lance.lmw...@gmail.com wrote: > > > On Tue, Jul 21, 2020 at 11:07:29AM +0200, Marton Balint wrote: > > > > > > > > > On Tue, 21 Jul 2020, lance.lmw...@gmail.com wrote: > > > > > > > On Mon, Jul 20, 2020

Re: [FFmpeg-devel] [PATCH 2/3] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-07-21 Thread lance . lmwang
On Mon, Jul 20, 2020 at 11:04:38PM +0200, Marton Balint wrote: > 50/60 fps timecode is using the field bit (which is the same as the phase > correction bit) to signal the least significant bit of a 50/60 fps timecode. > See SMPTE ST 12-1:2014 section 12.1. > > Let's add support for this by using t

Re: [FFmpeg-devel] [PATCH 2/3] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-07-22 Thread Marton Balint
On Wed, 22 Jul 2020, lance.lmw...@gmail.com wrote: On Mon, Jul 20, 2020 at 11:04:38PM +0200, Marton Balint wrote: 50/60 fps timecode is using the field bit (which is the same as the phase correction bit) to signal the least significant bit of a 50/60 fps timecode. See SMPTE ST 12-1:2014 secti