Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs: allow cbs_read_fragment_content() to discard units

2020-11-15 Thread James Almer
On 10/1/2020 9:38 PM, James Almer wrote: On 10/1/2020 8:57 PM, Mark Thompson wrote: On 20/09/2020 18:24, James Almer wrote: The caller may not need all units in a fragment in reading only scenarios. They could in fact alter global state stored in the private CodedBitstreamType fields in an unde

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs: allow cbs_read_fragment_content() to discard units

2020-10-01 Thread James Almer
On 10/1/2020 8:57 PM, Mark Thompson wrote: > On 20/09/2020 18:24, James Almer wrote: >> The caller may not need all units in a fragment in reading only >> scenarios. They >> could in fact alter global state stored in the private CodedBitstreamType >> fields in an undesirable way. >> And unlike prev

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs: allow cbs_read_fragment_content() to discard units

2020-10-01 Thread Mark Thompson
On 20/09/2020 18:24, James Almer wrote: The caller may not need all units in a fragment in reading only scenarios. They could in fact alter global state stored in the private CodedBitstreamType fields in an undesirable way. And unlike preventing decomposition of units, discarding can be done base

[FFmpeg-devel] [PATCH 2/4] avcodec/cbs: allow cbs_read_fragment_content() to discard units

2020-09-20 Thread James Almer
The caller may not need all units in a fragment in reading only scenarios. They could in fact alter global state stored in the private CodedBitstreamType fields in an undesirable way. And unlike preventing decomposition of units, discarding can be done based on parsed values within the unit. Signe