g.org
> > Subject: Re: [FFmpeg-devel] [PATCH 2/4] lavfi/opencl: Handle overlay
> input
> > formats correctly.
> >
> > On 29/10/18 05:56, Ruiling Song wrote:
> > > The main input may have alpha channel, we just ignore it.
> >
> > This doesn't ignore it -
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> Mark Thompson
> Sent: Sunday, November 11, 2018 9:55 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] lavfi/opencl: Handle overlay input
&
On 29/10/18 05:56, Ruiling Song wrote:
> The main input may have alpha channel, we just ignore it.
This doesn't ignore it - it leaves it uninitialised in the output, so a YUVA or
GBRAP output will never write to the A plane. I don't think that's what you're
intending.
> Also add some checks
> > > > > > > > The main input may have alpha channel, we just ignore it.
> > > > > > > > Also add some checks for incompatible input formats.
> > > > > > > >
> > > > > > > > Signed-off-by: Ruiling Song
> > > > > > LGTM.
> > > > > > BTW, could the main input with alpha case be supported?
> > > >
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> Li, Zhong
> Sent: Thursday, November 8, 2018 11:39 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] lavfi/opencl: Handle overl
> > -Original Message-
> > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On
> Behalf
> > Of Li, Zhong
> > Sent: Wednesday, November 7, 2018 4:37 PM
> > To: FFmpeg development discussions and patches
> >
> > Subject: Re: [FFmpeg-de
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> Li, Zhong
> Sent: Wednesday, November 7, 2018 4:37 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] lavfi/opencl: Handle overl
> > > > -Original Message-
> > > > From: Song, Ruiling
> > > > Sent: Monday, October 29, 2018 1:18 PM
> > > > To: ffmpeg-devel@ffmpeg.org
> > > > Cc: Song, Ruiling
> > > > Subject: [PATCH 2/4] lavfi/opencl: Handle overlay input formats
> correctly.
> > > >
> > > > The main input may have
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> Li, Zhong
> Sent: Wednesday, November 7, 2018 2:58 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] lavfi/opencl: Handle overl
> > -Original Message-
> > From: Song, Ruiling
> > Sent: Monday, October 29, 2018 1:18 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Song, Ruiling
> > Subject: [PATCH 2/4] lavfi/opencl: Handle overlay input formats correctly.
> >
> > The main input may have alpha channel, we just ignore it.
> -Original Message-
> From: Song, Ruiling
> Sent: Monday, October 29, 2018 1:18 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Song, Ruiling
> Subject: [PATCH 2/4] lavfi/opencl: Handle overlay input formats correctly.
>
> The main input may have alpha channel, we just ignore it.
> Also add
The main input may have alpha channel, we just ignore it.
Also add some checks for incompatible input formats.
Signed-off-by: Ruiling Song
---
libavfilter/vf_overlay_opencl.c | 58 -
1 file changed, 46 insertions(+), 12 deletions(-)
diff --git
The main input may have alpha channel, we just ignore it.
Also add some checks for incompatible input formats.
Signed-off-by: Ruiling Song
---
libavfilter/vf_overlay_opencl.c | 58 -
1 file changed, 46 insertions(+), 12 deletions(-)
diff --git
13 matches
Mail list logo
