Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-03-10 Thread Guo, Yejun
.org] On > > Behalf > > >> Of myp...@gmail.com > > >> Sent: Thursday, February 28, 2019 11:26 AM > > >> To: FFmpeg development discussions and patches > >> de...@ffmpeg.org> > > >> Subject: Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update R

Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-03-05 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Tuesday, March 05, 2019 8:52 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to >

Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-03-04 Thread Mark Thompson
de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to >> match documentation >> >> On Thu, Feb 28, 2019 at 10:53 AM Guo, Yejun wrote: >>>> -Original Message- >>>> From: ffmpeg-devel [mailto:ffm

Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-02-27 Thread Guo, Yejun
gt; > > Of Mark Thompson > > > Sent: Thursday, February 28, 2019 6:00 AM > > > To: ffmpeg-devel@ffmpeg.org > > > Subject: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to > > > match documentation > > > > > > Fix the quantisation offset -

Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-02-27 Thread myp...@gmail.com
rg > > Subject: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to > > match documentation > > > > Fix the quantisation offset - use the whole range, and don't change the > > offset size based on bit depth. > > > > Use correct botto

Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-02-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Thursday, February 28, 2019 6:00 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to > match d

[FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-02-27 Thread Mark Thompson
Fix the quantisation offset - use the whole range, and don't change the offset size based on bit depth. Use correct bottom/right edge locations (they are offsets from bottom/right, not from top/left). Iterate the list in reverse order. The regions are in order of decreasing importance, so the