Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2018-01-05 Thread Devin Heitmueller
Hello Aaron, Thanks for the feedback. Comments inline. On Sat, Dec 30, 2017 at 12:34 AM, Aaron Levinson wrote: > Technically, there are a number of 2K and 4K video modes supported by some > DeckLink cards that have a 16x9 aspect ratio as well. This code would treat

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 Thread Aaron Levinson
On 12/29/2017 1:20 PM, Devin Heitmueller wrote: On Dec 29, 2017, at 4:09 PM, Carl Eugen Hoyos wrote: 2017-12-29 22:02 GMT+01:00 Devin Heitmueller : On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos wrote: 2017-12-29 19:12

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 Thread Devin Heitmueller
> On Dec 29, 2017, at 4:09 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 22:02 GMT+01:00 Devin Heitmueller : >> >>> On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos wrote: >>> >>> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 Thread Carl Eugen Hoyos
2017-12-29 22:02 GMT+01:00 Devin Heitmueller : > >> On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos wrote: >> >> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : >> >>> +/* FIXME: Should really rely on the coded_width

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 Thread Devin Heitmueller
> On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > >> +/* FIXME: Should really rely on the coded_width but seems like that >> + is not accessible to libavdevice outputs */

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 Thread Carl Eugen Hoyos
2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > +/* FIXME: Should really rely on the coded_width but seems like that > + is not accessible to libavdevice outputs */ > +if ((st->codecpar->width == 1280 && st->codecpar->height == 720) || > +

[FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 Thread Devin Heitmueller
Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Updated to reflect feedback from Marton Balint Signed-off-by: Devin Heitmueller