Re: [FFmpeg-devel] [PATCH 3/3] avformat/aiffenc: Remove wrong and redundant check

2019-10-03 Thread Michael Niedermayer
On Wed, Oct 02, 2019 at 09:09:28AM +0200, Matthieu Bouron wrote: > On Wed, Oct 02, 2019 at 06:04:12AM +0200, Andreas Rheinhardt wrote: > > The check "if (!pb->seekable & AVIO_SEEKABLE_NORMAL)" is wrong, because > > ! has higher precendence than &. But it is also redundant, because this > > part of

Re: [FFmpeg-devel] [PATCH 3/3] avformat/aiffenc: Remove wrong and redundant check

2019-10-02 Thread Matthieu Bouron
On Wed, Oct 02, 2019 at 06:04:12AM +0200, Andreas Rheinhardt wrote: > The check "if (!pb->seekable & AVIO_SEEKABLE_NORMAL)" is wrong, because > ! has higher precendence than &. But it is also redundant, because this > part of the code is only ever reached when the AVIO_SEEKABLE_NORMAL flag > is set

[FFmpeg-devel] [PATCH 3/3] avformat/aiffenc: Remove wrong and redundant check

2019-10-01 Thread Andreas Rheinhardt
The check "if (!pb->seekable & AVIO_SEEKABLE_NORMAL)" is wrong, because ! has higher precendence than &. But it is also redundant, because this part of the code is only ever reached when the AVIO_SEEKABLE_NORMAL flag is set for pb. So simply remove the check. Signed-off-by: Andreas Rheinhardt ---