Re: [FFmpeg-devel] [PATCH 3/3] avformat: don't "merge" side data into packet data by default

2017-03-09 Thread Michael Niedermayer
On Thu, Mar 09, 2017 at 10:22:39AM +0100, wm4 wrote: > On Wed, 8 Mar 2017 15:44:36 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 08, 2017 at 01:40:12PM +0100, wm4 wrote: > > > Side data are separate AVPacket fields for a reason. Merging side data > > > requires

Re: [FFmpeg-devel] [PATCH 3/3] avformat: don't "merge" side data into packet data by default

2017-03-09 Thread wm4
On Wed, 8 Mar 2017 15:44:36 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 01:40:12PM +0100, wm4 wrote: > > Side data are separate AVPacket fields for a reason. Merging side data > > requires reallocating all packets, is complex, potentially clashes with > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat: don't "merge" side data into packet data by default

2017-03-08 Thread wm4
On Wed, 8 Mar 2017 15:44:36 +0100 Michael Niedermayer wrote: > On Wed, Mar 08, 2017 at 01:40:12PM +0100, wm4 wrote: > > Side data are separate AVPacket fields for a reason. Merging side data > > requires reallocating all packets, is complex, potentially clashes with > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat: don't "merge" side data into packet data by default

2017-03-08 Thread Michael Niedermayer
On Wed, Mar 08, 2017 at 01:40:12PM +0100, wm4 wrote: > Side data are separate AVPacket fields for a reason. Merging side data > requires reallocating all packets, is complex, potentially clashes with > "actual" packet data (you could probably come up with PCM data that > looks like merged side

[FFmpeg-devel] [PATCH 3/3] avformat: don't "merge" side data into packet data by default

2017-03-08 Thread wm4
Side data are separate AVPacket fields for a reason. Merging side data requires reallocating all packets, is complex, potentially clashes with "actual" packet data (you could probably come up with PCM data that looks like merged side data, or such), and could for example cause trouble to people