Re: [FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-11-02 Thread Lukasz Marek
On 2 November 2014 00:02, Reynaldo H. Verdejo Pinochet < reyna...@osg.samsung.com> wrote: > > > On 11/01/2014 07:59 PM, Lukasz Marek wrote: > > [..] > > > > I decreased it by 1 automatically rather than for any reason. I didn't > > want to change logic where it was not needed, and it was not neede

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-11-01 Thread Reynaldo H. Verdejo Pinochet
On 11/01/2014 07:59 PM, Lukasz Marek wrote: > [..] > > I decreased it by 1 automatically rather than for any reason. I didn't > want to change logic where it was not needed, and it was not needed > here. I guess you ask in general if there should be a limit (not just it > is 65535 or 6). I don't

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-11-01 Thread Lukasz Marek
On 01.11.2014 23:06, Reynaldo H. Verdejo Pinochet wrote: Hi On 10/31/2014 11:00 PM, Lukasz Marek wrote: [..] @@ -356,9 +356,7 @@ static int ffserver_parse_config_global(FFServerConfig *config, const char *cmd, if (!av_strcasecmp(cmd, "Port")) WARNING("Port option is dep

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-11-01 Thread Reynaldo H. Verdejo Pinochet
Hi On 10/31/2014 11:00 PM, Lukasz Marek wrote: > [..] > @@ -356,9 +356,7 @@ static int ffserver_parse_config_global(FFServerConfig > *config, const char *cmd, > if (!av_strcasecmp(cmd, "Port")) > WARNING("Port option is deprecated, use HTTPPort instead\n"); > ffserv

[FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-10-31 Thread Lukasz Marek
Replace atoi with more advanced parsing routine. Set maximum port value to 65535 (not 65536). Other checks. Signed-off-by: Lukasz Marek --- ffserver_config.c | 48 +++- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/ffserver_config.c b