Re: [FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

2014-09-03 Thread Reimar Döffinger
On Wed, Sep 03, 2014 at 07:36:32AM +0200, Reimar Döffinger wrote: > On 03.09.2014, at 06:28, Michael Niedermayer wrote: > > On Wed, Sep 03, 2014 at 12:01:54AM +0200, Reimar Döffinger wrote: > >> We only actually use a tiny part of it. > >> > >> Signed-off-by: Reimar Döffinger > >> --- > >> libsw

Re: [FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

2014-09-03 Thread Michael Niedermayer
On Wed, Sep 03, 2014 at 07:36:32AM +0200, Reimar Döffinger wrote: > On 03.09.2014, at 06:28, Michael Niedermayer wrote: > > On Wed, Sep 03, 2014 at 12:01:54AM +0200, Reimar Döffinger wrote: > >> We only actually use a tiny part of it. > >> > >> Signed-off-by: Reimar Döffinger > >> --- > >> libsw

Re: [FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

2014-09-02 Thread Reimar Döffinger
On 03.09.2014, at 06:28, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 12:01:54AM +0200, Reimar Döffinger wrote: >> We only actually use a tiny part of it. >> >> Signed-off-by: Reimar Döffinger >> --- >> libswresample/rematrix.c | 7 --- >> 1 file changed, 4 insertions(+), 3 deletions(

Re: [FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

2014-09-02 Thread Michael Niedermayer
On Wed, Sep 03, 2014 at 12:01:54AM +0200, Reimar Döffinger wrote: > We only actually use a tiny part of it. > > Signed-off-by: Reimar Döffinger > --- > libswresample/rematrix.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) i think there a multiple loops left that can access mor

[FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

2014-09-02 Thread Reimar Döffinger
We only actually use a tiny part of it. Signed-off-by: Reimar Döffinger --- libswresample/rematrix.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c index bf2abcf..60b8caf 100644 --- a/libswresample/rematrix.c +++ b/l