Re: [FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-25 Thread Michael Niedermayer
On Tue, Sep 03, 2019 at 07:52:35PM +0200, Nicolas George wrote: > James Almer (12019-09-03): > > I prefer a separate field. If the existing field was called in a more > > ambiguous way I'd be ok with reusing it, but not like this. > > Same for me. ok, will apply thanks [...] -- Michael

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-03 Thread Nicolas George
James Almer (12019-09-03): > I prefer a separate field. If the existing field was called in a more > ambiguous way I'd be ok with reusing it, but not like this. Same for me. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-03 Thread James Almer
On 9/3/2019 7:57 AM, Michael Niedermayer wrote: > On Tue, Sep 03, 2019 at 09:20:52AM +0200, Paul B Mahol wrote: >> NAK, you can use max_pixels for the same cause. > > yes, we can, its poor design though audio samples are not > pixels. > > Anyone else has an opinion on this ? > > Thanks I

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-03 Thread Tomas Härdin
tis 2019-09-03 klockan 13:10 +0200 skrev Michael Niedermayer: > On Tue, Sep 03, 2019 at 12:21:26PM +0200, Tomas Härdin wrote: > > tis 2019-09-03 klockan 09:20 +0200 skrev Paul B Mahol: > > > On 9/3/19, Michael Niedermayer wrote: > > > > TODO: APIChanges, bump version > > > > > > > >

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-03 Thread Michael Niedermayer
On Tue, Sep 03, 2019 at 12:21:26PM +0200, Tomas Härdin wrote: > tis 2019-09-03 klockan 09:20 +0200 skrev Paul B Mahol: > > > > On 9/3/19, Michael Niedermayer wrote: > > > TODO: APIChanges, bump version > > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-03 Thread Michael Niedermayer
On Tue, Sep 03, 2019 at 09:20:52AM +0200, Paul B Mahol wrote: > NAK, you can use max_pixels for the same cause. yes, we can, its poor design though audio samples are not pixels. Anyone else has an opinion on this ? Thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-03 Thread Tomas Härdin
tis 2019-09-03 klockan 09:20 +0200 skrev Paul B Mahol: > > On 9/3/19, Michael Niedermayer wrote: > > TODO: APIChanges, bump version > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/avcodec.h | 8 > > libavcodec/options_table.h | 1 + > >

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-03 Thread Paul B Mahol
NAK, you can use max_pixels for the same cause. On 9/3/19, Michael Niedermayer wrote: > TODO: APIChanges, bump version > > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h | 8 > libavcodec/options_table.h | 1 + >

[FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-02 Thread Michael Niedermayer
TODO: APIChanges, bump version Signed-off-by: Michael Niedermayer --- libavcodec/avcodec.h | 8 libavcodec/options_table.h | 1 + tests/ref/fate/api-mjpeg-codec-param | 2 ++ tests/ref/fate/api-png-codec-param | 2 ++ 4 files changed, 13 insertions(+) diff