Re: [FFmpeg-devel] [PATCH 3/9] avformat/matroskaenc: Use smaller types

2019-10-21 Thread Andreas Rheinhardt
On Tue, Oct 22, 2019 at 1:46 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > James Almer: > > On 10/15/2019 8:17 AM, Andreas Rheinhardt wrote: > >> Several members of structures denote offsets inside dynamic buffers and > >> therefore always fit into an int. So it is unnecessary to

Re: [FFmpeg-devel] [PATCH 3/9] avformat/matroskaenc: Use smaller types

2019-10-21 Thread Andreas Rheinhardt
James Almer: > On 10/15/2019 8:17 AM, Andreas Rheinhardt wrote: >> Several members of structures denote offsets inside dynamic buffers and >> therefore always fit into an int. So it is unnecessary to use an int64_t >> for them. > > True, but they are set using avio_tell() and then passed to

Re: [FFmpeg-devel] [PATCH 3/9] avformat/matroskaenc: Use smaller types

2019-10-21 Thread James Almer
On 10/15/2019 8:17 AM, Andreas Rheinhardt wrote: > Several members of structures denote offsets inside dynamic buffers and > therefore always fit into an int. So it is unnecessary to use an int64_t > for them. True, but they are set using avio_tell() and then passed to avio_seek(), both of which

[FFmpeg-devel] [PATCH 3/9] avformat/matroskaenc: Use smaller types

2019-10-15 Thread Andreas Rheinhardt
Several members of structures denote offsets inside dynamic buffers and therefore always fit into an int. So it is unnecessary to use an int64_t for them. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git