Re: [FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

2017-11-16 Thread Derek Buitenhuis
On 11/17/2017 12:38 AM, Devin Heitmueller wrote: > For whatever reason, the spec explicitly calls for the country code to be set > to these values. Here’s the specific language from the spec: > > itu_t_t35_country_code – A fixed 8-bit field, the value of which shall be > 0xB5. > itu_t_35_provid

Re: [FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

2017-11-16 Thread Devin Heitmueller
Hello Derek, Thanks for taking the time to review these patches. Comments below. > On Nov 16, 2017, at 7:20 PM, Derek Buitenhuis > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > >> +/* Active Format Description */ >> +if (x4->afd) { >> +void *sei_dat

Re: [FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

2017-11-16 Thread Derek Buitenhuis
On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > +/* Active Format Description */ > +if (x4->afd) { > +void *sei_data; > +size_t sei_size; > + > +ret = ff_alloc_afd_sei(frame, 0, &sei_data, &sei_size); > +if (ret < 0) { > +

[FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

2017-11-16 Thread Devin Heitmueller
If AFD side data is present, include it in an H.264 SEI payload when encoding with libx264. This is done in the same manner that we currently handle A53 closed captions (where the business logic for constructing the SEI is in libavcodec/utils.c), so it should be portable to the other encoder types