Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-14 Thread James Almer
On 6/14/2020 1:28 PM, Paul B Mahol wrote: > On 6/14/20, Jean-Baptiste Kempf wrote: >> On Sun, Jun 14, 2020, at 17:58, Paul B Mahol wrote: >>> On 6/14/20, Jean-Baptiste Kempf wrote: On Thu, Jun 11, 2020, at 17:37, Paul B Mahol wrote: > On 6/11/20, Michael Niedermayer wrote: >> On Wed

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-14 Thread Jean-Baptiste Kempf
On Sun, Jun 14, 2020, at 18:28, Paul B Mahol wrote: > > If you want this code remove, get it removed by either consensus or a vote. > > Not by screaming. > > You are mistaken, Mr. President. > This code is under codec cap experimental and can be removed at will. Experimental cap does not mean th

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-14 Thread Paul B Mahol
On 6/14/20, Jean-Baptiste Kempf wrote: > On Sun, Jun 14, 2020, at 17:58, Paul B Mahol wrote: >> On 6/14/20, Jean-Baptiste Kempf wrote: >> > On Thu, Jun 11, 2020, at 17:37, Paul B Mahol wrote: >> >> On 6/11/20, Michael Niedermayer wrote: >> >> > On Wed, May 20, 2020 at 08:59:20PM +0200, Michael N

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-14 Thread Jean-Baptiste Kempf
On Sun, Jun 14, 2020, at 17:58, Paul B Mahol wrote: > On 6/14/20, Jean-Baptiste Kempf wrote: > > On Thu, Jun 11, 2020, at 17:37, Paul B Mahol wrote: > >> On 6/11/20, Michael Niedermayer wrote: > >> > On Wed, May 20, 2020 at 08:59:20PM +0200, Michael Niedermayer wrote: > >> >> On Mon, May 11, 2020

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-14 Thread Paul B Mahol
On 6/14/20, Jean-Baptiste Kempf wrote: > On Thu, Jun 11, 2020, at 17:37, Paul B Mahol wrote: >> On 6/11/20, Michael Niedermayer wrote: >> > On Wed, May 20, 2020 at 08:59:20PM +0200, Michael Niedermayer wrote: >> >> On Mon, May 11, 2020 at 01:07:54AM +0200, Paul B Mahol wrote: >> >> > NAK >> >> >

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-14 Thread Jean-Baptiste Kempf
On Thu, Jun 11, 2020, at 17:37, Paul B Mahol wrote: > On 6/11/20, Michael Niedermayer wrote: > > On Wed, May 20, 2020 at 08:59:20PM +0200, Michael Niedermayer wrote: > >> On Mon, May 11, 2020 at 01:07:54AM +0200, Paul B Mahol wrote: > >> > NAK > >> > > >> > please remove this code fully. > >> > >>

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-11 Thread Paul B Mahol
On 6/11/20, Michael Niedermayer wrote: > On Wed, May 20, 2020 at 08:59:20PM +0200, Michael Niedermayer wrote: >> On Mon, May 11, 2020 at 01:07:54AM +0200, Paul B Mahol wrote: >> > NAK >> > >> > please remove this code fully. >> >> Id like to apply this and backport to the releases branches because

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-11 Thread Michael Niedermayer
On Wed, May 20, 2020 at 08:59:20PM +0200, Michael Niedermayer wrote: > On Mon, May 11, 2020 at 01:07:54AM +0200, Paul B Mahol wrote: > > NAK > > > > please remove this code fully. > > Id like to apply this and backport to the releases branches because > sonic is in the releases > are you ok with

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-05-20 Thread Michael Niedermayer
On Mon, May 11, 2020 at 01:07:54AM +0200, Paul B Mahol wrote: > NAK > > please remove this code fully. Id like to apply this and backport to the releases branches because sonic is in the releases are you ok with that ? Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-05-10 Thread Paul B Mahol
NAK please remove this code fully. On 5/10/20, Michael Niedermayer wrote: > Fixes: signed integer overflow: -234 * -14797801 cannot be represented in > type 'int' > Fixes: > 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5695924975435776 > > Found-by: continuous fuzzing pro

[FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-05-10 Thread Michael Niedermayer
Fixes: signed integer overflow: -234 * -14797801 cannot be represented in type 'int' Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5695924975435776 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi