Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-31 Thread Andreas Cadhalpun
On 31.01.2017 13:45, Ronald S. Bultje wrote: > I don't want this patch. I also don't want to discuss it further. Please > remove the log message. Thank you. For the sake of ending this, I've removed them. Please avoid complaining about log messages for my future patches. Thank you. Best regards,

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-31 Thread Clément Bœsch
On Tue, Jan 31, 2017 at 07:45:56AM -0500, Ronald S. Bultje wrote: > Hi, > > On Mon, Jan 30, 2017 at 8:52 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > > > Marton proposed a way to mitigate this [1], but you haven't commented > > on it so far. > > > It doesn't mitigate

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-31 Thread Ronald S. Bultje
Hi, On Mon, Jan 30, 2017 at 8:52 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Marton proposed a way to mitigate this [1], but you haven't commented > on it so far. It doesn't mitigate it. Source code is still an issue, as is binary size if CONFIG_SMALL is off, which is

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-30 Thread Andreas Cadhalpun
On 30.01.2017 17:17, Ronald S. Bultje wrote: > On Sun, Jan 29, 2017 at 7:37 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 29.01.2017 04:46, Ronald S. Bultje wrote: >>> Hm ... So I guess I wasn't clear about this, but the reason I didn't >> reply >>> to other patches

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-30 Thread Ronald S. Bultje
Hi, On Sun, Jan 29, 2017 at 7:37 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 29.01.2017 04:46, Ronald S. Bultje wrote: > > Hm ... So I guess I wasn't clear about this, but the reason I didn't > reply > > to other patches with log messages was not because I'm OK with,

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-29 Thread Andreas Cadhalpun
On 29.01.2017 04:46, Ronald S. Bultje wrote: > Hm ... So I guess I wasn't clear about this, but the reason I didn't reply > to other patches with log messages was not because I'm OK with, but simply > to keep the discussion contained in a single thread and not spam the list. > I'd prefer if the

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-28 Thread Ronald S. Bultje
Hi, On Sat, Jan 28, 2017 at 7:25 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 27.01.2017 03:27, Michael Niedermayer wrote: > > On Thu, Jan 26, 2017 at 02:14:09AM +0100, Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun > >>

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-28 Thread Andreas Cadhalpun
On 27.01.2017 03:27, Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:14:09AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/boadec.c | 14 +- >> 1 file changed, 13 insertions(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2017 at 02:14:09AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/boadec.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-25 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavformat/boadec.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavformat/boadec.c b/libavformat/boadec.c index ac2a33b3f0..6055effcad 100644 --- a/libavformat/boadec.c +++