Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-04-03 Thread Limin Wang
On Fri, Mar 27, 2020 at 01:47:10AM +0100, Michael Niedermayer wrote: > On Thu, Mar 26, 2020 at 10:47:37AM +0100, Anton Khirnov wrote: > > Quoting Andreas Rheinhardt (2020-03-20 17:51:41) > > > Jan Ekström: > > > > On Fri, Mar 20, 2020 at 5:45 PM wrote: > > > >> > > > >> From: Limin Wang > > > >>

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-26 Thread Michael Niedermayer
On Thu, Mar 26, 2020 at 10:47:37AM +0100, Anton Khirnov wrote: > Quoting Andreas Rheinhardt (2020-03-20 17:51:41) > > Jan Ekström: > > > On Fri, Mar 20, 2020 at 5:45 PM wrote: > > >> > > >> From: Limin Wang > > >> > > >> This fixes webvtt segment output. > > >> > > >> Please testing with the foll

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-20 17:51:41) > Jan Ekström: > > On Fri, Mar 20, 2020 at 5:45 PM wrote: > >> > >> From: Limin Wang > >> > >> This fixes webvtt segment output. > >> > >> Please testing with the following command and check the output: > >> ./ffmpeg -i ../fate-suite/sub/MicroDVD_c

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-20 Thread Limin Wang
On Fri, Mar 20, 2020 at 06:03:53PM +0200, Jan Ekström wrote: > On Fri, Mar 20, 2020 at 5:45 PM wrote: > > > > From: Limin Wang > > > > This fixes webvtt segment output. > > > > Please testing with the following command and check the output: > > ./ffmpeg -i ../fate-suite/sub/MicroDVD_capability_te

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-20 Thread Andreas Rheinhardt
Jan Ekström: > On Fri, Mar 20, 2020 at 5:45 PM wrote: >> >> From: Limin Wang >> >> This fixes webvtt segment output. >> >> Please testing with the following command and check the output: >> ./ffmpeg -i ../fate-suite/sub/MicroDVD_capability_tester.srt -f segment >> -segment_time 10 \ >> -segm

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-20 Thread Jan Ekström
On Fri, Mar 20, 2020 at 6:12 PM Nicolas George wrote: > > Jan Ekström (12020-03-20): > > I do wonder if this is just a case of people forgetting to set the > > flag for the relevant packets in the relevant modules? > > > > I'm not sure if all API users should be forced to handle this > > separatel

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-20 Thread Nicolas George
Jan Ekström (12020-03-20): > I do wonder if this is just a case of people forgetting to set the > flag for the relevant packets in the relevant modules? > > I'm not sure if all API users should be forced to handle this > separately. If the packets are decode'able by themselves, they should > be ma

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-20 Thread Jan Ekström
On Fri, Mar 20, 2020 at 5:45 PM wrote: > > From: Limin Wang > > This fixes webvtt segment output. > > Please testing with the following command and check the output: > ./ffmpeg -i ../fate-suite/sub/MicroDVD_capability_tester.srt -f segment > -segment_time 10 \ > -segment_list_size 0 -segmen

[FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-20 Thread lance . lmwang
From: Limin Wang This fixes webvtt segment output. Please testing with the following command and check the output: ./ffmpeg -i ../fate-suite/sub/MicroDVD_capability_tester.srt -f segment -segment_time 10 \ -segment_list_size 0 -segment_list sub.m3u8 -segment_format webvtt -scodec webvtt s