On Sun, Jun 10, 2018 at 5:28 PM Nicolas George wrote:
>
> Jun Zhao (2018-06-10):
> > v1: - Replace magic number by micro for bprint init
>
> I will not oppose the patch series, but I think it is useless clutter of
> the history. The special values are not magic, they are logical or
> standard.
>
>
myp...@gmail.com (2018-06-11):
> > How about change the commit message with "Replace the number by micro
> > for code code readability"?
I do not think it increases code readability. If somebody knows the API,
the semantic of the special values is obvious. If not, the extra
information is not hel
On Mon, Jun 11, 2018 at 8:48 AM myp...@gmail.com wrote:
>
> On Sun, Jun 10, 2018 at 5:28 PM Nicolas George wrote:
> >
> > Jun Zhao (2018-06-10):
> > > v1: - Replace magic number by micro for bprint init
> >
> > I will not oppose the patch series, but I think it is useless clutter of
> > the histo
On Sun, Jun 10, 2018 at 5:28 PM Nicolas George wrote:
>
> Jun Zhao (2018-06-10):
> > v1: - Replace magic number by micro for bprint init
>
> I will not oppose the patch series, but I think it is useless clutter of
> the history. The special values are not magic, they are logical or
> standard.
How
Jun Zhao (2018-06-10):
> v1: - Replace magic number by micro for bprint init
I will not oppose the patch series, but I think it is useless clutter of
the history. The special values are not magic, they are logical or
standard.
But if anybody applies this, please fix the typo in the commit message
v1: - Replace magic number by micro for bprint init
Jun Zhao (11):
fftools/cmdutils: Replace magic number by micro for bprint init
fftools/ffmpeg: Replace magic number by micro for bprint init
fftools/ffmpeg_filter: Replace magic number by micro for bprint init
lavc/dvdsubenc: Replace magi
