Re: [FFmpeg-devel] [PATCH v14 1/2] avformat/imf: Demuxer

2021-12-26 Thread Pierre-Anthony Lemieux
On Fri, Dec 24, 2021 at 4:08 PM Zane van Iperen wrote: > > Looks mostly alright, just some style nits. Once they're fixed, lgtm. > > On Wednesday, 22 December 2021 4:42:08 AM AEST p...@sandflow.com wrote: > > > + > > +int ff_imf_xml_read_uuid(xmlNodePtr element, uint8_t uuid[16]) > > +{ > > +x

Re: [FFmpeg-devel] [PATCH v14 1/2] avformat/imf: Demuxer

2021-12-24 Thread Zane van Iperen
Looks mostly alright, just some style nits. Once they're fixed, lgtm. On Wednesday, 22 December 2021 4:42:08 AM AEST p...@sandflow.com wrote: > + > +int ff_imf_xml_read_uuid(xmlNodePtr element, uint8_t uuid[16]) > +{ > +xmlChar *element_text = NULL; > +int scanf_ret; > +int ret = 0; >

[FFmpeg-devel] [PATCH v14 1/2] avformat/imf: Demuxer

2021-12-21 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: The IMF demuxer accepts as input an IMF CPL. The assets referenced by the CPL can be contained in multiple deliveries, each defined by an ASSETMAP file: ffmpeg -assetmaps ,,... -i If -asset