Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-03-07 Thread wm4
On Thu, 2 Mar 2017 09:58:28 -0800 Aman Gupta wrote: > On Thu, Mar 2, 2017 at 1:34 AM, wm4 wrote: > > > On Tue, 21 Feb 2017 13:40:08 -0800 > > Aman Gupta wrote: > > > > > On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-03-06 Thread wm4
On Thu, 2 Mar 2017 09:58:28 -0800 Aman Gupta wrote: > On Thu, Mar 2, 2017 at 1:34 AM, wm4 wrote: > > > On Tue, 21 Feb 2017 13:40:08 -0800 > > Aman Gupta wrote: > > > > > On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-03-02 Thread Aman Gupta
On Thu, Mar 2, 2017 at 1:34 AM, wm4 wrote: > On Tue, 21 Feb 2017 13:40:08 -0800 > Aman Gupta wrote: > > > On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje > > wrote: > > > > > Hi, > > > > > > On Tue, Feb 21, 2017 at 1:48 PM, Aman

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-03-02 Thread wm4
On Tue, 21 Feb 2017 13:40:08 -0800 Aman Gupta wrote: > On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje > wrote: > > > Hi, > > > > On Tue, Feb 21, 2017 at 1:48 PM, Aman Gupta wrote: > > > >> diff --git a/libavcodec/h264dec.c

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread wm4
On Tue, 21 Feb 2017 10:48:37 -0800 Aman Gupta wrote: > From: Aman Gupta > > The way videotoolbox hooks in as a hwaccel is pretty hacky. The VT decode > API is not invoked until end_frame(), so alloc_frame() returns a dummy > frame with a 1-byte buffer. When

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread Aman Gupta
On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Feb 21, 2017 at 1:48 PM, Aman Gupta wrote: > >> diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c >> index 41c0964392..a0ae632fed 100644 >> --- a/libavcodec/h264dec.c >> +++

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread Ronald S. Bultje
Hi, On Tue, Feb 21, 2017 at 1:48 PM, Aman Gupta wrote: > diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c > index 41c0964392..a0ae632fed 100644 > --- a/libavcodec/h264dec.c > +++ b/libavcodec/h264dec.c > @@ -850,7 +850,12 @@ static int output_frame(H264Context *h,

[FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread Aman Gupta
From: Aman Gupta The way videotoolbox hooks in as a hwaccel is pretty hacky. The VT decode API is not invoked until end_frame(), so alloc_frame() returns a dummy frame with a 1-byte buffer. When end_frame() is eventually called, the dummy buffer is replaced with the actual decoded