Re: [FFmpeg-devel] [PATCH v2] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-11-06 Thread Hendrik Leppkes
On Tue, Nov 6, 2018 at 9:02 AM Valery Kot wrote: > > On Mon, Nov 5, 2018 at 4:50 PM Mark Thompson wrote: > > > > LGTM, tested and applied. > > > > - Mark > > Thanks! > > Is it also possible to apply this patch on release/4.1 branch, so that > it will end up in the next release? > Unfortunately,

Re: [FFmpeg-devel] [PATCH v2] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-11-06 Thread Valery Kot
On Mon, Nov 5, 2018 at 4:50 PM Mark Thompson wrote: > > LGTM, tested and applied. > > - Mark Thanks! Is it also possible to apply this patch on release/4.1 branch, so that it will end up in the next release? Valery ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH v2] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-11-05 Thread Mark Thompson
On 01/11/18 13:24, Valery Kot wrote: > On Thu, Nov 1, 2018 at 1:55 PM Valery Kot wrote: >> >>> I think this would look nicer (and generate less code) as a table + loop >>> rather than an if-ladder making each fraction structure inline? >>> >>> E.g. something like >>>

[FFmpeg-devel] [PATCH v2] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-11-01 Thread Valery Kot
On Thu, Nov 1, 2018 at 1:55 PM Valery Kot wrote: > > > I think this would look nicer (and generate less code) as a table + loop > > rather than an if-ladder making each fraction structure inline? > > > > E.g. something like > >