Re: [FFmpeg-devel] [PATCH v2] avcodec/mips: [loongson] refine process of setting block as 0 in h264dsp_mmi.

On Sun, Jul 28, 2019 at 04:07:40PM +0200, Reimar Döffinger wrote: > I have no MIPS experience, but for what little it is worth thus: it looks > fine to me. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written

Re: [FFmpeg-devel] [PATCH v2] avcodec/mips: [loongson] refine process of setting block as 0 in h264dsp_mmi.

I have no MIPS experience, but for what little it is worth thus: it looks fine to me. On 28.07.2019, at 06:42, Shiyou Yin wrote: > In function ff_h264_add_pixels4_8_mmi, there is no need to reset '%[ftmp0]' > to 0, because it's value has never changed since the start of the asm block. > This pa

[FFmpeg-devel] [PATCH v2] avcodec/mips: [loongson] refine process of setting block as 0 in h264dsp_mmi.

In function ff_h264_add_pixels4_8_mmi, there is no need to reset '%[ftmp0]' to 0, because it's value has never changed since the start of the asm block. This patch remove the redundant 'xor' and set src to zero once it was loaded. In function ff_h264_idct_add_8_mmi, 'block' is seted to zero twice.