Re: [FFmpeg-devel] [PATCH v2] avcodec/vvc/refs: remove early return

2025-06-28 Thread Marvin Scholz
On 28 Jun 2025, at 3:42, Frank Plowman wrote: > On 27/06/2025 00:23, Marvin Scholz wrote: >> The ret value is checked later on again, so this check >> is redundant and would cause the frame to not be unrefd on >> failure as well. >> >> So remove this check and add one before av_frame_remove_sid

Re: [FFmpeg-devel] [PATCH v2] avcodec/vvc/refs: remove early return

2025-06-27 Thread Frank Plowman
On 27/06/2025 00:23, Marvin Scholz wrote: > The ret value is checked later on again, so this check > is redundant and would cause the frame to not be unrefd on > failure as well. > > So remove this check and add one before av_frame_remove_side_data > to ensure it is not called with an invalid fram

[FFmpeg-devel] [PATCH v2] avcodec/vvc/refs: remove early return

2025-06-26 Thread Marvin Scholz
The ret value is checked later on again, so this check is redundant and would cause the frame to not be unrefd on failure as well. So remove this check and add one before av_frame_remove_side_data to ensure it is not called with an invalid frame. Fix CID 1648350 --- libavcodec/vvc/refs.c | 5 ++-