Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Nicolas George
Steven Liu (12020-03-20): > Yes, av_strtok get the first part and the other part, > And use the strtol get the first part to long, it check the string range, and > get the endpoint of (not number part.) > The end is same as the first part. My exact comment was wrong. The actual problem is that av

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Steven Liu
> 2020年3月20日 下午8:25,Nicolas George 写道: > >> The end can be null, there can only maxFrameRate=25, or maxFrameRate=60/2. > > It is a value from the outside, you can't trust it on pail of security > exploit. Yes, av_strtok get the first part and the other part, And use the strtol get the first pa

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Nicolas George
Steven Liu (12020-03-20): > To: Nicolas George Please heed reply-to headers. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-deve

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Nicolas George
Steven Liu (12020-03-20): > Which one leak? if xmlGetProp return null, val should null and dose not leak. Yes, my mistake. > The end can be null, there can only maxFrameRate=25, or maxFrameRate=60/2. It is a value from the outside, you can't trust it on pail of security exploit. > Just tell the

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Steven Liu
> 2020年3月20日 下午7:19,Nicolas George 写道: > > Steven Liu (12020-03-20): >> These member will be used for get more correct information of the MPD >> >> Suggested-by: Andreas Rheinhardt >> Suggested-by: Nicolas George >> Signed-off-by: Steven Liu >> --- >> libavformat/dashdec.c | 180 +++

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Nicolas George
Steven Liu (12020-03-20): > These member will be used for get more correct information of the MPD > > Suggested-by: Andreas Rheinhardt > Suggested-by: Nicolas George > Signed-off-by: Steven Liu > --- > libavformat/dashdec.c | 180 +++--- > 1 file changed, 15

[FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-19 Thread Steven Liu
These member will be used for get more correct information of the MPD Suggested-by: Andreas Rheinhardt Suggested-by: Nicolas George Signed-off-by: Steven Liu --- libavformat/dashdec.c | 180 +++--- 1 file changed, 151 insertions(+), 29 deletions(-) diff --g