On Wed, May 08, 2019 at 09:28:33PM +0200, Reimar Döffinger wrote:
> On Wed, May 08, 2019 at 03:06:37PM +0530, Swaraj Hota wrote:
> > On Wed, May 08, 2019 at 12:52:01AM +0200, Reimar Döffinger wrote:
> > > First, seeking should be handled specially, by resetting the state.
> > > You should not make
On Wed, May 08, 2019 at 03:06:37PM +0530, Swaraj Hota wrote:
> On Wed, May 08, 2019 at 12:52:01AM +0200, Reimar Döffinger wrote:
> > First, seeking should be handled specially, by resetting the state.
> > You should not make the get_packet less efficient because of that.
> > That should enable the
On Wed, May 08, 2019 at 12:52:01AM +0200, Reimar Döffinger wrote:
> On 07.05.2019, at 12:00, Swaraj Hota wrote:
>
> > On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote:
> >>
> >>
> >>> +/*read video index*/
> >>> +avio_seek(s->pb, 0xf8, SEEK_SET);
> >> [...]
> >>> +
On 08.05.2019, at 08:01, Carl Eugen Hoyos wrote:
> Am Mi., 8. Mai 2019 um 00:52 Uhr schrieb Reimar Döffinger
> :
>>
>> On 07.05.2019, at 12:00, Swaraj Hota wrote:
>>
>>> On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote:
> +/*read video index*/
> +
Am Mi., 8. Mai 2019 um 00:52 Uhr schrieb Reimar Döffinger
:
>
> On 07.05.2019, at 12:00, Swaraj Hota wrote:
>
> > On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote:
> >>
> >>
> >>> +/*read video index*/
> >>> +avio_seek(s->pb, 0xf8, SEEK_SET);
> >> [...]
> >>> +
On 07.05.2019, at 12:00, Swaraj Hota wrote:
> On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote:
>>
>>
>>> +/*read video index*/
>>> +avio_seek(s->pb, 0xf8, SEEK_SET);
>> [...]
>>> +avio_skip(s->pb, ifv->vid_index->frame_offset - avio_tell(s->pb));
>>
>> Why use
On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote:
> Hello!
> Nothing major, but a few comments on things that might make
> sense to polish below.
>
> On Sat, May 04, 2019 at 06:42:40PM +0530, Swaraj Hota wrote:
> > +#define IFV_MAGIC "\x11\xd2\xd3\xab\xba\xa9\xcf\x11\
> >
On Sun, May 05, 2019 at 10:05:17PM +0200, Carl Eugen Hoyos wrote:
> Am So., 5. Mai 2019 um 21:59 Uhr schrieb Reimar Döffinger
> :
> > > +if (aud_magic == MKTAG('G','R','A','W')) {
> > > +ifv->is_audio_present = 1;
> > > +} else if (aud_magic == MKTAG('P','C','M','U')) {
> > > +
Am So., 5. Mai 2019 um 21:59 Uhr schrieb Reimar Döffinger
:
> > +avio_skip(s->pb, 0x5c);
>
> If for any of these skips you have any idea what data they
> contain, it would be nice to document it.
Iirc, all values we understood are used now.
> > +if (aud_magic == MKTAG('G','R','A','W'))
Hello!
Nothing major, but a few comments on things that might make
sense to polish below.
On Sat, May 04, 2019 at 06:42:40PM +0530, Swaraj Hota wrote:
> +#define IFV_MAGIC "\x11\xd2\xd3\xab\xba\xa9\xcf\x11\
> +\x8e\xe6\x00\xc0\x0c\x20\x53\x65\x44"
> +if (!memcmp(p->buf, IFV_MAGIC, 17))
Some more or less important issues found:
On 5/4/19, Swaraj Hota wrote:
> Fixes ticket #2956.
>
> Signed-off-by: Swaraj Hota
> ---
> Revised patch. Made some minor changes based on original player:
> - Removed incorrect reading of frame_rate, instead frame rate
> is kept fixed at 25 (seems like
On 5/4/19, Swaraj Hota wrote:
> Okay. Thanks!
>
Sorry, but I found some issues while testing your patch.
Why are there no timestamps?
Seeking with mpv/ffplay caused hard crash.
You do not handle EOF, so ffmpeg with .ivf never exits.
___
Okay. Thanks!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On 5/4/19, Swaraj Hota wrote:
> Fixes ticket #2956.
>
> Signed-off-by: Swaraj Hota
> ---
> Revised patch. Made some minor changes based on original player:
> - Removed incorrect reading of frame_rate, instead frame rate
> is kept fixed at 25 (seems like this value is always same).
> - Added
Fixes ticket #2956.
Signed-off-by: Swaraj Hota
---
Revised patch. Made some minor changes based on original player:
- Removed incorrect reading of frame_rate, instead frame rate
is kept fixed at 25 (seems like this value is always same).
- Added reading of frame width and height from input file.
15 matches
Mail list logo
